From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36485@debbugs.gnu.org
Subject: bug#36485: [PATCH] Improve some menus with separators and better wording
Date: Fri, 13 Sep 2019 20:57:24 +0200 [thread overview]
Message-ID: <CADwFkmkcZzne2g0ME1WD2KWkSx7dQsVGOgOTy4VTfnp74sMSoQ@mail.gmail.com> (raw)
In-Reply-To: <83zhlvbduq.fsf@gnu.org>
tags 36485 + fixed
close 36485 27.1
close
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Wed, 3 Jul 2019 09:17:42 +0200
>>
>> Just a small patch to add menu separators to some menus that are
>> missing them.
>
> What were the criteria for determining that a separator is missing in
> a particular place?
>
> Adding separators makes the menus longer, which could be a problem,
> especially on TTY frames with a small number of lines (like 24). So
> we need to add them judiciously.
Thanks for reviewing the change. Looking back at the suggestion, my
criteria were admittedly pretty ad hoc, and I had completely forgotten
about the menu on the console.
Taking another look now, I think the only important change here is a
typo which I fixed in commit 224534ab8d.
With that, I'm closing this bug report.
Best regards,
Stefan Kangas
prev parent reply other threads:[~2019-09-13 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:17 bug#36485: [PATCH] Improve some menus with separators and better wording Stefan Kangas
2019-07-03 10:40 ` Eli Zaretskii
2019-07-04 20:14 ` Juri Linkov
2019-09-13 18:57 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkcZzne2g0ME1WD2KWkSx7dQsVGOgOTy4VTfnp74sMSoQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=36485@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.