bug#29192: 26.0.90; flymake-warning's default color might be inappropriate

bug#29192: 26.0.90; flymake-warning's default color might be inappropriate

[Dmitry Gutov]

I've never seen this discussed, and this might be a subjective opinion.

But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
it's an obsolete alias). Flycheck also uses this color for warnings.

Flymake's own fringe indicators (for warning) also use an orange color
by default, inheriting it from the `warning' face through
`compilation-warning'.

So I think that flymake-warning should use it as well.

The current blue is pretty and all, but it conveys an optimistic mood,
not something I would associate with a warning.

+++

In GNU Emacs 26.0.90 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
  of 2017-11-07 built on zappa
Repository revision: ca2d94ba61dee678f85bfc7299d167e7219e6d8f
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04

bug#29192: 26.0.90; flymake-warning's default color might be inappropriate

[Stefan Kangas]

Dmitry Gutov <dgutov@yandex.ru> writes:

> I've never seen this discussed, and this might be a subjective opinion.
>
> But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
> it's an obsolete alias). Flycheck also uses this color for warnings.
>
> Flymake's own fringe indicators (for warning) also use an orange color
> by default, inheriting it from the `warning' face through
> `compilation-warning'.
>
> So I think that flymake-warning should use it as well.
>
> The current blue is pretty and all, but it conveys an optimistic mood,
> not something I would associate with a warning.

Make sense.  Could you make that change?

Best regards,
Stefan Kangas

bug#29192: 26.0.90; flymake-warning's default color might be inappropriate

[Dmitry Gutov]

Hi Stefan,

On 10.08.2020 19:25, Stefan Kangas wrote:
>> But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
>> it's an obsolete alias). Flycheck also uses this color for warnings.
>>
>> Flymake's own fringe indicators (for warning) also use an orange color
>> by default, inheriting it from the `warning' face through
>> `compilation-warning'.
>>
>> So I think that flymake-warning should use it as well.
>>
>> The current blue is pretty and all, but it conveys an optimistic mood,
>> not something I would associate with a warning.
> Make sense.  Could you make that change?

Thank you for the response, but I have warmed up to this new color in 
the years since the change was made. Maybe not very indicative of being 
a warning, it is nevertheless more noticeable than DarkOrange.

Which is a nice property to have.

If you really like the suggestion, I welcome you to play with the color 
change a little. Otherwise, we can just close this.

bug#29192: 26.0.90; flymake-warning's default color might be inappropriate

[Stefan Kangas]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Thank you for the response, but I have warmed up to this new color in the years
> since the change was made. Maybe not very indicative of being a warning, it is
> nevertheless more noticeable than DarkOrange.
>
> Which is a nice property to have.
>
> If you really like the suggestion, I welcome you to play with the
> color change a little. Otherwise, we can just close this.

That sounds good to me so I'll just close this.  Thanks!

Best regards,
Stefan Kangas