From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter navigation time grows as sqrt(line-number) Date: Thu, 31 Aug 2023 22:24:03 +0200 Message-ID: References: <3E82D409-6903-4679-9031-939CA35791FF@gmail.com> <32507689-3b2c-ccbf-dd14-e7bf0bed1ac7@gutov.dev> <6db52945-5459-197c-405d-153ff395a824@gutov.dev> <1F7C956D-6D22-4CC1-8656-6E2A4D07D5FB@gmail.com> <69D18963-D94F-4792-9FF1-159897A99E50@gmail.com> <48CD64C5-CC2A-42C5-8496-33B188497B99@gmail.com> <831qfjg34v.fsf@gnu.org> <32BD183F-2E89-4EF4-B5D5-A3F9FE64178D@gmail.com> <83il8vc9pp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24687"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , jdtsmith@gmail.com, dmitry@gutov.dev, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 22:25:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qboE9-0006AV-4s for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 22:25:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qboDL-0004fh-5m; Thu, 31 Aug 2023 16:24:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qboDH-0004fU-DE for emacs-devel@gnu.org; Thu, 31 Aug 2023 16:24:23 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qboDC-00011r-C6; Thu, 31 Aug 2023 16:24:21 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-5007abb15e9so2382879e87.0; Thu, 31 Aug 2023 13:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693513456; x=1694118256; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ptYD4O/vAh1Up7/fhAPb9GC7vEXqraLMzMfBXVzz71Q=; b=X8ck+KM5/u0qFehHI95orh7pzz/qAz56UrCcejee48b8WRw/EYPR78nuf1KRsT89VX Zl0qKdgoV2FQG/C9c+0LIzqU4BEmVAvGaITp2OBouSlF/7GB0s+nmxIOz1UIeX7JxV2/ O28xZiP9YpTnm7fFUmz1KUO8S7wHds2MvqjSEkvut6NhVk4RPxG3oTAo5OrPCO0G4wNb r95mVmOlpuPMNCFgNNNzupBEu3eEvFHb1pbnCLW57c78EYyayHJPXn5yAUuGnynDbFMc nylBXhbhaXnBbkWd8vmCjPxctHOmIPdaOYQ+JI8YiMzz3vlpsiq0XDmF9MhnT1ti9Wmr nyVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693513456; x=1694118256; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ptYD4O/vAh1Up7/fhAPb9GC7vEXqraLMzMfBXVzz71Q=; b=jlzIZTXsfEVuUcQtmxUyzZpuv+un1FeBCUmE7tKD15A1Y+hGr8634IUnLiE2FOTBlD Daf74oL/5EmDsVRgCPBerwMKlFQAtcAa3wtXr+dmaUmACE7TunD+HPTlEV5Gae9lLOl8 66XBlbTu5NjlWgA65Jror0jO7kZt0mo9Zti3IaHyAcd1QqEP/Qq/63tJ7bC99MHMFLo0 Xu6gB9prh/5HdfjrsnMESRbqXasWgRpdysk8PRU66gMV4r4az+tQ0RQzmh03fHpGJXWE f+yroUkl9CIjzYMFeQJxOPE8tTlB1S8QlPeMSwq7Jt+2Rw6hoVJe9z4t6+nOtIij40KP CO+Q== X-Gm-Message-State: AOJu0YzFxqMXtMr9Mi98RpLaPhGeWMtNg5wMlk9iq6EbLT6wcNFCcUC+ AkyOYVHODhKcGuELcSCpZX6qSD+zqix4tAmEWo3Hu6Xy2u0= X-Google-Smtp-Source: AGHT+IFdWsOuflAmjnqRLcQ+RBHQDOjf2mxW30kUH0kQgWxuadtxdr2ACdDuHqAcGgif0l65crAk21m6nSPYb7v/29s= X-Received: by 2002:ac2:4c45:0:b0:4fe:629:9265 with SMTP id o5-20020ac24c45000000b004fe06299265mr309654lfk.20.1693513455489; Thu, 31 Aug 2023 13:24:15 -0700 (PDT) In-Reply-To: <83il8vc9pp.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=stefankangas@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309695 Archived-At: Eli Zaretskii writes: > Stefan, WDYT about this? I admit I'm a bit weary, but everyone else > seems to think this is a bugfix. I'm not sure I can be of much help here; I really haven't been following treesitter development very closely. Having looked at the patch, the fix is also slightly less trivial than I had hoped, in the sense that I don't understand it. :-) That said, I do think that stability expectations might be a bit different for a completely new and (arguably) semi-optional feature. Yuan Fu's stated opinion up-thread was that the patch is "relatively safe". If it was up to me, I'd probably keep it on emacs-29, with a readiness to revert if any issues were to crop up. But I won't object either way.