all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: enquiries@vsm.in, 18573@debbugs.gnu.org
Subject: bug#18573: 24.3.93; set-face-attribute crashes Emacs when started with -nw
Date: Thu, 26 Sep 2019 22:57:26 +0200	[thread overview]
Message-ID: <CADwFkmkbZ1jW5eyp9Nhjb87eyy8uY7sfgN_=Z376QA6tiLDABQ@mail.gmail.com> (raw)
In-Reply-To: <5426E238.6060301@vsm.in>

fixed 18573 24.4
close 18573
quit

Jan Djärv <jan.h.d@swipnet.se> writes:

> For now I comitted the "wont crash" solution (don't execute the code for tty
> frames) in the emacs 24 branch.  No error is signalled and no looping is done to
> find a GUI frame.  I'm not sure if we should do that.

I think that fixed the issue; I can no longer reproduce it.

I don't see anything else outstanding, besides the FIXME added in:

commit 335e9627ca78f7be9eea27f38a530fd51a1e6995
Author: Jan Djärv <jan.h.d@swipnet.se>
Date:   Wed Oct 1 20:10:21 2014 +0200

    * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.

But that is just a possible improvement, and keeping this bug open won't
do much to help direct any efforts to doing that.  If anything it will
confuse it by mixing it up with a crash that has been fixed for a long
time.

I'm therefore closing this bug.  If anyone disagrees, feel free to
reopen.

Best regards,
Stefan Kangas





      parent reply	other threads:[~2019-09-26 20:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 16:13 bug#18573: 24.3.93; set-face-attribute crashes Emacs on OS X 10.9.4 enquiries
2014-09-28  8:44 ` bug#18573: 24.3.93; set-face-attribute crashes Emacs when started with -nw Jan Djärv
2014-09-28 12:24   ` enquiries
2014-10-01 16:49     ` Glenn Morris
2014-10-01 17:55       ` Stefan Monnier
2014-09-29 17:18   ` Eli Zaretskii
2014-09-29 17:34     ` enquiries
2014-10-01 17:43     ` Jan Djärv
2014-10-01 17:49       ` Eli Zaretskii
2014-10-01 18:11         ` Jan Djärv
2014-10-01 18:16           ` Eli Zaretskii
2019-09-26 20:57 ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkbZ1jW5eyp9Nhjb87eyy8uY7sfgN_=Z376QA6tiLDABQ@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=18573@debbugs.gnu.org \
    --cc=enquiries@vsm.in \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.