From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: About the new frame title Date: Thu, 24 Sep 2020 01:57:38 -0700 Message-ID: References: <963461223.1300042.1600072070148@mail1.libero.it> <83sgbk9ylm.fsf@gnu.org> <152448855.1272757.1600098758378@mail1.libero.it> <83imc93k5d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000006b0b3205b00b645a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: angelo.g0@libero.it, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 24 10:58:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLN5H-0000q8-6g for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 10:58:35 +0200 Original-Received: from localhost ([::1]:51448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLN5G-0000Wz-9c for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 04:58:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLN4R-0008S8-G6 for emacs-devel@gnu.org; Thu, 24 Sep 2020 04:57:43 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:45232) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLN4P-0002SX-Ly; Thu, 24 Sep 2020 04:57:43 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id i26so3328217ejb.12; Thu, 24 Sep 2020 01:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=VYu/AXMUGW+TwQwGt9xnrUeL4oZyDWvO40/B0bY+690=; b=lhuRIS4cpM0K4I0wAC0N2zIjZ0ctKyK/4i6zHVWSTytQfscpqwpg2ftSEuDxY1CbIc ir2PMJ5pdyEa49qjn7MLWx/ysGuODETE7D8EyU/Nwiff/fvqlAZkVjIjSlft3MPN26Ez 0pqCUpalpnGhoZ8bF9PaCmbSMvUEa0lmpTaLd69oh4GyzYktzSVCRXMU1Yk5rB2HLGBC FZtP5bmTlN/Z4iYf5HBM5bDTRcTW/Inq2JAU11Z7c9K/N0bIPNTycmlaRyd577aP1lMh srnGjWhiboE/RBBGAQs3Fu8jn+DIYZ9xatzmXNzxErmrZ8c6EbvQpBe7eEh0KMb+yN+0 TFGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=VYu/AXMUGW+TwQwGt9xnrUeL4oZyDWvO40/B0bY+690=; b=W9feFwA91vVjXoqM99rb0NyjdDeGhDXnJJbNp2/qP/iYEzYFGPZsRglSeQ51W8SNTt 09tyx9MIkSrdk1vyFJmld+HgNE/+fmzKm6UYoSimC75grAQi06zI0LJVHubpAAOhfSoG L+J3Q+nAGpB2GDYhOdzDck66eZdoGHaCNIltSGZL4S962kMik2bSem6ib5CIzWQHPE+Z 3MjgWa3qnTaDeWsXgbbbnZstfkQZ+jgS7xQToRWtvWKZ7VaF5xFGtxTP73U9PjKT1ymv eaL0+FnaSqV2pLfpgK6hUF5AOmhdl0xOB6aP7EBaTGrXI9BSIug9NHW2gDQ7x/y48GKi midg== X-Gm-Message-State: AOAM533tVIDacVHPWoQkh/BSK1iGhtPiIRO3JbHOSewqePdwYGO72SGa 6S7yG05vjmxRZI9VErJHUyxcZ+pMa+fcoI1jsS5icfaM X-Google-Smtp-Source: ABdhPJwTZQTKmhyagTObTGvPllWbWvK28EAuh6ejD4nMGByfXdUSdx+SsU5Pnydaud/h17fRDbFTgKLI8I37isBcD/8= X-Received: by 2002:a17:906:1b15:: with SMTP id o21mr3461302ejg.377.1600937859409; Thu, 24 Sep 2020 01:57:39 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Sep 2020 01:57:38 -0700 In-Reply-To: <83imc93k5d.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=stefankangas@gmail.com; helo=mail-ej1-x62c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256391 Archived-At: --0000000000006b0b3205b00b645a Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> dpyinfo->name_list_element = Fcons (display_name, Qnil); >> if (STRINGP (Vsystem_name)) >> { >> - dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name) >> - + SCHARS (Vsystem_name) + 2); >> - sprintf (dpyinfo->w32_id_name, "%s@%s", >> - SDATA (Vinvocation_name), SDATA (Vsystem_name)); >> + dpyinfo->w32_id_name = xmalloc (14 + SCHARS (Vsystem_name)); >> + sprintf (dpyinfo->w32_id_name, "GNU Emacs at %s", SDATA (Vsystem_name)); > > Please don't use hard-coded constants, like 14 above, in such cases. > Instead, use sizeof to compute the correct size at compile time from > the string used as format specifier. Thanks. Does the attached look better? --0000000000006b0b3205b00b645a Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Make-initial-frame-match-frame-title-format.patch" Content-Disposition: attachment; filename="0001-Make-initial-frame-match-frame-title-format.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 83852e48498c4f63_0.1 RnJvbSA0NjIxNGZjZDZkYjU1YjJjNzE4MzZkMmQzMDU0ZmFiZTI4NjBjOWExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAxOSBTZXAgMjAyMCAxNDoxMzo1MiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug aW5pdGlhbCBmcmFtZSBtYXRjaCBmcmFtZS10aXRsZS1mb3JtYXQKCiogc3JjL3h0ZXJtLmMgKHhf dGVybV9pbml0KToKKiBzcmMvdzMydGVybS5jICh3MzJfaW5pdGlhbGl6ZV9kaXNwbGF5X2luZm8p OiBTeW5jIGluaXRpYWwgZnJhbWUKdGl0bGUgd2l0aCBuZXcgdmFsdWUgb2YgVmZyYW1lX3RpdGxl X2Zvcm1hdC4KUHJvYmxlbSByZXBvcnRlZCBieSBBbmdlbG8gR3Jhemlvc2kgPGFuZ2Vsby5nMEBs aWJlcm8uaXQ+LgotLS0KIHNyYy93MzJ0ZXJtLmMgfCAxNCArKysrKysrKystLS0tLQogc3JjL3h0 ZXJtLmMgICB8IDI1ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwg MjQgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3czMnRl cm0uYyBiL3NyYy93MzJ0ZXJtLmMKaW5kZXggMjY2OWYyOWI1Ni4uMjA2YjVlY2I4MiAxMDA2NDQK LS0tIGEvc3JjL3czMnRlcm0uYworKysgYi9zcmMvdzMydGVybS5jCkBAIC03MTY1LDE1ICs3MTY1 LDE5IEBAIHczMl9pbml0aWFsaXplX2Rpc3BsYXlfaW5mbyAoTGlzcF9PYmplY3QgZGlzcGxheV9u YW1lKQogICBtZW1zZXQgKGRweWluZm8sIDAsIHNpemVvZiAoKmRweWluZm8pKTsKIAogICBkcHlp bmZvLT5uYW1lX2xpc3RfZWxlbWVudCA9IEZjb25zIChkaXNwbGF5X25hbWUsIFFuaWwpOworICBj b25zdCBjaGFyICp0aXRsZTsKICAgaWYgKFNUUklOR1AgKFZzeXN0ZW1fbmFtZSkpCiAgICAgewot ICAgICAgZHB5aW5mby0+dzMyX2lkX25hbWUgPSB4bWFsbG9jIChTQ0hBUlMgKFZpbnZvY2F0aW9u X25hbWUpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICsgU0NIQVJTIChW c3lzdGVtX25hbWUpICsgMik7Ci0gICAgICBzcHJpbnRmIChkcHlpbmZvLT53MzJfaWRfbmFtZSwg IiVzQCVzIiwKLSAgICAgICAgICAgICAgIFNEQVRBIChWaW52b2NhdGlvbl9uYW1lKSwgU0RBVEEg KFZzeXN0ZW1fbmFtZSkpOworICAgICAgdGl0bGUgPSAiR05VIEVtYWNzIGF0ICI7CisgICAgICBk cHlpbmZvLT53MzJfaWRfbmFtZSA9IHhtYWxsb2MgKHNpemVvZiAodGl0bGUpICsgU0NIQVJTIChW c3lzdGVtX25hbWUpKTsKKyAgICAgIHNwcmludGYgKGRweWluZm8tPnczMl9pZF9uYW1lLCAiJXMl cyIsIHRpdGxlLCBTREFUQSAoVnN5c3RlbV9uYW1lKSk7CiAgICAgfQogICBlbHNlCi0gICAgZHB5 aW5mby0+dzMyX2lkX25hbWUgPSB4bGlzcHN0cmR1cCAoVmludm9jYXRpb25fbmFtZSk7CisgICAg eworICAgICAgdGl0bGUgPSAiR05VIEVtYWNzIjsKKyAgICAgIGRweWluZm8tPnczMl9pZF9uYW1l ID0geG1hbGxvYyAoc2l6ZW9mICh0aXRsZSkpOworICAgICAgc3ByaW50ZiAoZHB5aW5mby0+dzMy X2lkX25hbWUsICIlcyIsIHRpdGxlKTsKKyAgICB9CiAKICAgLyogRGVmYXVsdCBDb25zb2xlIG1v ZGUgdmFsdWVzIC0gb3ZlcnJpZGRlbiB3aGVuIHJ1bm5pbmcgaW4gR1VJIG1vZGUKICAgICAgd2l0 aCB2YWx1ZXMgb2J0YWluZWQgZnJvbSBzeXN0ZW0gbWV0cmljcy4gICovCmRpZmYgLS1naXQgYS9z cmMveHRlcm0uYyBiL3NyYy94dGVybS5jCmluZGV4IDJlMDQwN2FmZjQuLjYyNmYwNjZiY2EgMTAw NjQ0Ci0tLSBhL3NyYy94dGVybS5jCisrKyBiL3NyYy94dGVybS5jCkBAIC0xMjkyNywxOSArMTI5 MjcsMjQgQEAgI2RlZmluZSBOVU1fQVJHViAxMAogI2VuZGlmCiAKICAgTGlzcF9PYmplY3Qgc3lz dGVtX25hbWUgPSBGc3lzdGVtX25hbWUgKCk7Ci0KLSAgcHRyZGlmZl90IG5ieXRlcyA9IFNCWVRF UyAoVmludm9jYXRpb25fbmFtZSkgKyAxOwotICBpZiAoU1RSSU5HUCAoc3lzdGVtX25hbWUpCi0g ICAgICAmJiBJTlRfQUREX1dSQVBWIChuYnl0ZXMsIFNCWVRFUyAoc3lzdGVtX25hbWUpICsgMSwg Jm5ieXRlcykpCi0gICAgbWVtb3J5X2Z1bGwgKFNJWkVfTUFYKTsKLSAgZHB5aW5mby0+eF9pZCA9 ICsreF9kaXNwbGF5X2lkOwotICBkcHlpbmZvLT54X2lkX25hbWUgPSB4bWFsbG9jIChuYnl0ZXMp OwotICBjaGFyICpuYW1ldGFpbCA9IGxpc3BzdHBjcHkgKGRweWluZm8tPnhfaWRfbmFtZSwgVmlu dm9jYXRpb25fbmFtZSk7CisgIGNvbnN0IGNoYXIgKnRpdGxlOwogICBpZiAoU1RSSU5HUCAoc3lz dGVtX25hbWUpKQogICAgIHsKLSAgICAgICpuYW1ldGFpbCsrID0gJ0AnOwotICAgICAgbGlzcHN0 cGNweSAobmFtZXRhaWwsIHN5c3RlbV9uYW1lKTsKKyAgICAgIHRpdGxlID0gIkdOVSBFbWFjcyBh dCAiOworICAgICAgcHRyZGlmZl90IG5ieXRlcyA9IHNpemVvZiAodGl0bGUpOworICAgICAgaWYg KElOVF9BRERfV1JBUFYgKG5ieXRlcywgU0JZVEVTIChzeXN0ZW1fbmFtZSksICZuYnl0ZXMpKQor CW1lbW9yeV9mdWxsIChTSVpFX01BWCk7CisgICAgICBkcHlpbmZvLT54X2lkX25hbWUgPSB4bWFs bG9jIChuYnl0ZXMpOworICAgICAgc3ByaW50ZihkcHlpbmZvLT54X2lkX25hbWUsICIlcyVzIiwg dGl0bGUsIFNEQVRBIChzeXN0ZW1fbmFtZSkpOwogICAgIH0KKyAgZWxzZQorICAgIHsKKyAgICAg IHRpdGxlID0gIkdOVSBFbWFjcyI7CisgICAgICBkcHlpbmZvLT54X2lkX25hbWUgPSB4bWFsbG9j IChzaXplb2YgKHRpdGxlKSk7CisgICAgICBzcHJpbnRmIChkcHlpbmZvLT54X2lkX25hbWUsICIl cyIsIHRpdGxlKTsKKyAgICB9CisKKyAgZHB5aW5mby0+eF9pZCA9ICsreF9kaXNwbGF5X2lkOwog CiAgIC8qIEZpZ3VyZSBvdXQgd2hpY2ggbW9kaWZpZXIgYml0cyBtZWFuIHdoYXQuICAqLwogICB4 X2ZpbmRfbW9kaWZpZXJfbWVhbmluZ3MgKGRweWluZm8pOwotLSAKMi4yOC4wCgo= --0000000000006b0b3205b00b645a--