From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package proposal: git-modes Date: Thu, 21 Oct 2021 19:13:08 -0700 Message-ID: References: <875ytuyzmk.fsf@bernoul.li> <871r4fzfyq.fsf@posteo.net> <87k0i5ex9j.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35150"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jonas Bernoulli , rms@gnu.org, Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 22 04:13:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdk45-0008wD-8Z for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Oct 2021 04:13:49 +0200 Original-Received: from localhost ([::1]:45336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdk43-0005Cm-H4 for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Oct 2021 22:13:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdk3U-0004X9-DP for emacs-devel@gnu.org; Thu, 21 Oct 2021 22:13:12 -0400 Original-Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:39743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdk3S-0008GG-HY; Thu, 21 Oct 2021 22:13:12 -0400 Original-Received: by mail-pj1-x102a.google.com with SMTP id u6-20020a17090a3fc600b001a00250584aso4575689pjm.4; Thu, 21 Oct 2021 19:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=b28VNGFAtxvkTJNRql7fhUV0uzoBqRIumusgT+TocPw=; b=kmPdOB/WO+kmQR/gb4h8WX/LFcL7nHeiUTFdSBzD/PsFSI5zN5L5/1IzUuJc961LnE +EF/o4wXx9GFjrjbmVTSITYU2roqx1atlbrgglcU5v7Aw9aahwSPM7UY+mDNze46TS3D BQc1YUG/+gfhhLXTNLN6Qvo3LwobzklgdapM9HvQDzWt5EYybWelz3C94MDkZlDR1CL8 BLkkV75ZkKcICUI2rE70cVb6Jm7f0ta4yx2LORx9T4DbY2402HzL4lba1Q7dxDhQPdYs Q0NFHM+X9Mm9Qe1D68/j5VoJpPuhqxpQZ5UN7Jv38yU0+hbAIFZr3TxdBl3/MmobYVY+ IQrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=b28VNGFAtxvkTJNRql7fhUV0uzoBqRIumusgT+TocPw=; b=2KmQKoVg4ANbx/ClGcrUwfyPQAJDE3xHBoggfJK7YVJPVDxVx4r8Zc4//pYkE6iTpc eVXYscPxeDIANRHxT+IiyiF4iCczYPEGdpZvwMuH/HSk1wVAQMkLUCbPnYN53NCHR2vD 9sOY1TZxUfA3vnBssJUnjsuZFYq7lD0PFz38hP8vhpWrNmiPm66DdOjmMpIULB7Z3DbR i4cIs2KfQ0zhUQqaHoq4YMhwB4i9kHTKTOYRpl9iV98bJrMWJOYHzMI3wavUd7H8PEEn etKMdZujAaj7ldsZilf9nw8DxJRUSN4Y8yjgVHrl25K63fuoSgGJieZ7if0qx8Cbru0S mUzw== X-Gm-Message-State: AOAM532TwdIBHBghML2XEdo/2i2CCv4WkT9eNcJx/vws+Ts6m2NXSZ0Y kf/nC2a2XB7v7Oe8o7rPgHn/wDBShmRvWpFfPCSwegLK X-Google-Smtp-Source: ABdhPJwdBPME0FVxiG1N72eoDjQhpSIRzT4le6t9UDUTqueWFAHgxI3N7Ps2PWBP2NTvcaD8qlZCJ/7lWSyd+2ugzQ0= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr11020456pjb.132.1634868788738; Thu, 21 Oct 2021 19:13:08 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 19:13:08 -0700 In-Reply-To: <87k0i5ex9j.fsf@bernoul.li> Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=stefankangas@gmail.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277541 Archived-At: Jonas Bernoulli writes: >> That's a shame. But how big is per code? >> Would it be feasible to write new code to replace that code? > > It's not a of code: gitconfig-mode: 137, gitignore-mode: 61, > gitattributes-mode 232 lines, all including headers. IMO it > would make sense to re-implement them. > > gitignore-mode is completely trivial, basically just font-lock keywords. Couldn't .gitignore-mode basically just be replaced with `conf-unix-mode'? I have gitignore-mode running locally, but I'm not sure the syntax highlighting it does have is very helpful. Why highlight "/" in "foo/bar", for example? This would be a trivial addition to auto-mode-alist in emacs-28, if that's something we want to do. > gitconfig-mode has more font-lock keywords plus some indentation code, > which I personally find more annoying than helpful. By default, we use `conf-mode' for these files, which already looks pretty good to my eyes. Is gitconfig-mode much better? > gitattributes-mode is more complex, also including support for eldoc and > some navigation commands. The good news is that in this case we might > actually be able to get all the required copyright assignments. That's good news, indeed.