From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#30990: Should the byte compiler warn about :type mismatches? Date: Sat, 28 Sep 2019 21:00:22 +0200 Message-ID: References: <87woxu7rf8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="201559"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Alex Branham , 30990@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 28 21:04:55 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEI1W-000qKP-Lo for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 21:04:54 +0200 Original-Received: from localhost ([::1]:34558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEI1V-0008A1-18 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 15:04:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45790) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEHxn-0004yK-U8 for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:01:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEHxm-0004LF-QQ for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEHxm-0004Jp-Mi for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEHxm-00051m-Ha for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:01:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87woxu7rf8.fsf@gmail.com> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30990 X-GNU-PR-Package: emacs Original-Received: via spool by 30990-submit@debbugs.gnu.org id=B30990.156969724219292 (code B ref 30990); Sat, 28 Sep 2019 19:01:02 +0000 Original-Received: (at 30990) by debbugs.gnu.org; 28 Sep 2019 19:00:42 +0000 Original-Received: from localhost ([127.0.0.1]:51277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEHxS-000516-4U for submit@debbugs.gnu.org; Sat, 28 Sep 2019 15:00:42 -0400 Original-Received: from mail-pg1-f194.google.com ([209.85.215.194]:42506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEHxP-00050r-Pe for 30990@debbugs.gnu.org; Sat, 28 Sep 2019 15:00:40 -0400 Original-Received: by mail-pg1-f194.google.com with SMTP id z12so5145548pgp.9 for <30990@debbugs.gnu.org>; Sat, 28 Sep 2019 12:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ARf6kvLkTc8cJwu2z7DPBrVZcprl6XOFNIoYZFwg1nU=; b=mKKrOPLHSf2fkx6nP7JZv2PNP3+1qnXc7XMxUb0e7zVro5efh1M+Yj5kEgB7NfgGPT 3mJ5RskwIWXguQuwDvw66SXZVnsNh5x1kUpxNTT41iSST6ODeoQQMJFokrMOtr/HLjl0 xWiv+ssTuEfvpx5d5JtHiQIRCO8yFtG02phkrY4gqas4c4BzNrc7vBus/6r8tQ6g4Nz2 vllFDinAXDMpkWtS0rVJW0JI0rqUILesa1ZjyWD256UNjgO1nQla+anqY32uIooNx6H6 cN2CQr/3ve4OEfpKFvh8xLPL/Rsto6wFxXV6gORJOWXiUz29yxlV0vWPmTMOcjCw6gUr Ehrg== X-Gm-Message-State: APjAAAU0RHKiAO4rHUosIkBrPt94tBkUt8D7WnHGDoKsnO4XNZd/GHF0 Ch6zhoEBh0dSFnfv0g3RdSHJBKxTHyEcVPZg2Hg= X-Google-Smtp-Source: APXvYqw7ewL48pY2u3epDotyQZkKEl7n3CMilBerZcvR3/5sDslDwIxJg/bLjCfh1QXK+wFHiKgA/liEwnlpKH8iiu8= X-Received: by 2002:a62:e917:: with SMTP id j23mr12229157pfh.50.1569697234062; Sat, 28 Sep 2019 12:00:34 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167519 Archived-At: Glenn Morris writes: > Alex Branham wrote: > >> Would it be possible/desirable to make the byte-compiler warn about >> :type mismatches with defcustoms? > > I think that to do this in general requires evaluating the defcustom at > compile time, which probably isn't the right thing. > > emacs -batch -l admin/cus-test.el -f cus-test-opts all > > will find these mismatches. I think it should be converted to an > (expensive) ert test, which would solve the problem for Emacs itself. I think that's a good idea. Running the above command in my tree, I get: The following options might have problems: sql-password-wallet tramp-default-host-alist display-fill-column-indicator-character bibtex-string-file-path js-jsx-indent-level bibtex-file-path sql-use-indent-support sql-postgres-login-params winner-boring-buffers-regexp add-log-dont-create-changelog-file nnir-notmuch-filter-group-names-function flymake-cc-command Since we're getting closer to the release of Emacs 27.1, perhaps we should sort these out. Best regards, Stefan Kangas