From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rms@gnu.org, joaotavora@gmail.com, emacs-devel@gnu.org,
stephen_leake@stephe-leake.org
Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list
Date: Fri, 28 Oct 2022 23:52:11 -0700 [thread overview]
Message-ID: <CADwFkmkW9vfR-GqGtjxuh6Dd92h-PJ45jAfZLeZ4MNSg3Vy0ow@mail.gmail.com> (raw)
In-Reply-To: <8335b7jhqj.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> They also make patches harder to review, sometimes much harder.
Fully agreed. That's why I'd prefer it if people would make whitespace
changes separately from functional changes. Our current rule
unfortunately seems to encourage putting it all in the same patch.
Personally, I try to edit out most whitespace changes from my patches.
But occasionally, the temptation of fixing some egregious indentation is
too big, also for me.
> Not as long as the "diff" operation of the VCS treats whitespace as
> significant by default. Presumably, they do this for a reason, and
> therefore patches we get to review do not ignore whitespace.
It's hard to hope for a change in that default in Git itself, as long as
whitespace is significant in some languages. Fortunately, that's not
the case for Emacs Lisp or C.
next prev parent reply other threads:[~2022-10-29 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org>
[not found] ` <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org>
2022-10-25 9:29 ` master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list João Távora
2022-10-25 9:35 ` João Távora
2022-10-27 20:13 ` Richard Stallman
2022-10-28 5:42 ` Eli Zaretskii
2022-10-28 8:32 ` João Távora
2022-10-28 11:30 ` Eli Zaretskii
2022-10-28 19:45 ` Stefan Kangas
2022-10-29 5:56 ` Eli Zaretskii
2022-10-29 6:52 ` Stefan Kangas [this message]
2022-10-29 7:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkW9vfR-GqGtjxuh6Dd92h-PJ45jAfZLeZ4MNSg3Vy0ow@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=rms@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.