From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch to add tab bar support to the nextstep port Date: Fri, 15 Oct 2021 15:58:48 +0200 Message-ID: References: <21FA04FD-9B55-4A04-9835-1ED4034F185E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Emacs developers To: Illia Ostapyshyn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 15:59:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbNkW-0001W7-Kp for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 15:59:52 +0200 Original-Received: from localhost ([::1]:39500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbNkV-0001jP-Lp for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 09:59:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbNji-00012w-Pr for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:59:02 -0400 Original-Received: from mail-pj1-f42.google.com ([209.85.216.42]:54186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbNjh-00020y-Bp for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:59:02 -0400 Original-Received: by mail-pj1-f42.google.com with SMTP id ls18so7245592pjb.3 for ; Fri, 15 Oct 2021 06:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXTcm7s8roFVMFsrIrcGbFCWul59qXvtKGbcYomXm3U=; b=sO+iopLmGbNfB2WoWxsBWdcl53EFbyfaPIUHRtyKujNRNzrnClkL8X/V0DNDG3ZPQ4 TuRYoHHVgKv9pHp/PkP4ImwOhBBcGXyw/ljktsMALSwWfUgDnl9o1i554kVHT8D2nfE+ mPszeX6KIjuRQV5AT8T6TiIUFyJbSy8XFXiJR9EWWTKByTQxYSqWMKwwkSvjnbYLuO1b BMJB5DIqoL08jiFl4D2W5TUgosVvqbmzugQ2gb2vdMqF97j8ZND5I1EYXjFLjch/lhFd vX9aGVtUbn2V/5/TlZ/LJaKyoYKue4AZzJwwaM/vix3sWpxDymejtB6nneVAl63pwZ0W 6Etw== X-Gm-Message-State: AOAM531xa2JFcXm8gJf9sXi0GVhj+F+5Co00ajgEy/IL3Edynl17lOlw 6rsDUbW0jUJXUE/MHAy50W4JE7Ml2rpwwmGB5Ys= X-Google-Smtp-Source: ABdhPJxbEKyLEASHficaL8JQd7o23MVyaRxTaKDEMa5GphCGNK33nmBEGOvogO767hH5B5vH6j5B5VTD3RZCRA+Qqdo= X-Received: by 2002:a17:90a:c70d:: with SMTP id o13mr28026068pjt.143.1634306339551; Fri, 15 Oct 2021 06:58:59 -0700 (PDT) In-Reply-To: <21FA04FD-9B55-4A04-9835-1ED4034F185E@gmail.com> Received-SPF: pass client-ip=209.85.216.42; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f42.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277124 Archived-At: Illia Ostapyshyn writes: > Just as I was looking into this myself, Po Lu delivers :-) Thank you! > > Tested on MacBookPro15,2, Big Sur 11.6. Would also hope to see this installed in emacs-28 branch. I have tested this patch on my MacBook Pro from 2015, running High Sierra 10.13.6, and it seems to work as it should from my light testing. I will continue running it and report back if I run into any issues. BTW, I included my hardware above because Illia did so, but does the exact hardware matter for our purposes? I would like to know whether I should make including that information a habit, as until now I have only included the version of macOS.