From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Tue, 23 Aug 2022 12:53:29 -0700 Message-ID: References: <83sflqcfhk.fsf@gnu.org> <83tu65br5f.fsf@gnu.org> <83r119bp35.fsf@gnu.org> <83lere7p5z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, mathias.dahl@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 23 21:54:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQZyh-0008rV-QD for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 21:54:23 +0200 Original-Received: from localhost ([::1]:39914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQZyg-0007uH-Ka for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 15:54:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQZxs-0007EG-Mk for emacs-devel@gnu.org; Tue, 23 Aug 2022 15:53:32 -0400 Original-Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]:33366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQZxr-0007zW-3j; Tue, 23 Aug 2022 15:53:32 -0400 Original-Received: by mail-vs1-xe33.google.com with SMTP id l7so15260260vsc.0; Tue, 23 Aug 2022 12:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc; bh=zSWLXqC3gmfwZ7kWwQ00e+XOtqkay0xQk0MpCvA38hQ=; b=Y7FgZVEXagX5X5RFswFNtuRUk2TJNFBfBNxdRpjJz59NDlXnn5//rnSsnA0JMW2VZv a1o3jdOaPTgzxqvIG/O/TyWWS4qS7PFp3nnq5hqUVaVCMt40TbpeQjX6Mlo8Ag5RvmtM +j3tSj2FdWsG9CSwbDOOrwW28EXrn7XrTZDt+HgfN8d3CeWNuUFPm8yYwpt92PPC08ej uNubYcpapImlSM3sa3vTnkCla6dfSmIBYA6bLDUFw4CdH5aHBnwKA1BH/YL2H6+3Ok9E 2MchTsX2NcbnRW1/GgjA93o1wgah2Q1cPqkK8EYLPCsJ/t23wz4BaP0WHgTV0GBAllMV sz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc; bh=zSWLXqC3gmfwZ7kWwQ00e+XOtqkay0xQk0MpCvA38hQ=; b=uUs+xqXwxhptp/wgBdHo+LTNVPcdzgYbdeueyAnWe8b4HSfrBK5dwKVzfIOSf/JbbY p+QBXdbRMRkbrUyt8nZTAKLBUUfyxHTQWXMUXodNUsVl57enQjxcmQJpTL+LG+yo4Z85 qpQF8pYx5PJlC8vk8Ua8bKO0TsEapmTJvm5utz+A/n/CfM9uN+aGzlNOStkHc+gNtsYG Ly20rcCWUMYsFu5ghXwHLtcWOgf5JlyI37FFqUqhZ5BZTi2HwojsNY1Mau3t2SgqtzBA jESGpgz4nB9Zo3rqJI8YRK9DwPx4enK0tnbd/vU5vRHkRr9KGs7RYs8JGBPqnPQoA9de +52A== X-Gm-Message-State: ACgBeo37v53TayCH3P6DL1de6sJSfdt29OEz26sHXdbLnhYR338+Y5Cg lMcw73f8kGGD7swESVA+eYNM19HxgX4HA6FZEMC7FTfi X-Google-Smtp-Source: AA6agR4fE4ZYqq92aJUOiiP0dUXZVgbZq/lGpQmERtsXNZus+WwfIcw87yS8SgCgbWBJqKzFgJBATmoTdQVQEVEJvcM= X-Received: by 2002:a67:e195:0:b0:390:62b1:518d with SMTP id e21-20020a67e195000000b0039062b1518dmr4703128vsl.85.1661284409663; Tue, 23 Aug 2022 12:53:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Aug 2022 12:53:29 -0700 In-Reply-To: <83lere7p5z.fsf@gnu.org> X-Hashcash: 1:20:220823:mathias.dahl@gmail.com::HvuTZEQsVrCxMrSl:0Dvx Received-SPF: pass client-ip=2607:f8b0:4864:20::e33; envelope-from=stefankangas@gmail.com; helo=mail-vs1-xe33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293918 Archived-At: Eli Zaretskii writes: > Yes, I think this is the wrong way of dividing the big file into > several smaller ones. You don't go by dependencies, you go by > functionalities. If I understand you correctly, that's what I've done: image-dired-dired.el image-dired-external.el image-dired-tags.el image-dired.el I don't currently see how dividing "by functionality" helps with image-dired-util.el, however. image-dired-*.el still has to build. I also fear that the overall structure will be worse if we go out of our way just to get rid of one file. OTOH, I note that Gnus, Viper, MH-E, URL, Eshell, etc. all have some util-file, so the idea isn't completely new or foreign to Emacs. If there are no better ideas for how to structure this, I'm personally happy with what is currently on scratch/image-dired. But ideas are of course still welcome, and I especially welcome concrete ones.