From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#75451: scratch/igc: Enable CHECK_STRUCTS Date: Thu, 9 Jan 2025 01:20:38 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11705"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd Moellmann , 75451-done@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 08:21:27 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVmr8-0002uW-M3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 08:21:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVmqr-0006rb-VA; Thu, 09 Jan 2025 02:21:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVmql-0006qs-IG for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:21:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVmql-0005as-0k for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:21:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=csj2V8v4onXXcENY8LDpP3CpZGTrutHjbvLRmUPW/HE=; b=AjtBfxLlr/4QKcMp81oF34XOkbQmEhaJgddzYvdKYKraqMVWZoB7ajzIWDuNWg0IOfC9xnenfNRHh6FBKtFrlBgnjXVANxjhfLylGxRYT6XsawzQMt/lTN3lZbvfdnxy7D/GLJdBoIAw2DzHv5HXiuCqcPoGEs6EuSkCSM8cGdNMiPIqqmsxJ8DmxGFTE2cYONCmb3ZfTnD1krJoN9q3/JZlrtVZIL9xcUPh7CxpGdNu7EEU2G2olMpXFKz/ytVaU+nob6+L050HUpAomFr5W04NvVwDdhQBZPRyKukwEUthIyoi3mqof1ibD1WEvHAgjVjVhOwUFWM1BQbudMf9JQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVmqk-0006ew-PX for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:21:02 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 75451 X-GNU-PR-Package: emacs Mail-Followup-To: 75451@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 75451-done@debbugs.gnu.org id=D75451.173640724825554 (code D ref 75451); Thu, 09 Jan 2025 07:21:02 +0000 Original-Received: (at 75451-done) by debbugs.gnu.org; 9 Jan 2025 07:20:48 +0000 Original-Received: from localhost ([127.0.0.1]:50201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVmqW-0006e5-1X for submit@debbugs.gnu.org; Thu, 09 Jan 2025 02:20:48 -0500 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:55799) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVmqU-0006df-7a for 75451-done@debbugs.gnu.org; Thu, 09 Jan 2025 02:20:47 -0500 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5d3d14336f0so834051a12.3 for <75451-done@debbugs.gnu.org>; Wed, 08 Jan 2025 23:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736407240; x=1737012040; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=csj2V8v4onXXcENY8LDpP3CpZGTrutHjbvLRmUPW/HE=; b=TV+lnbWwZcjy7Wd9i+GkhDGyWIaMZHTqPlRpPzcANo8h6x8b42PmrbpZupUxuG93uX CTfUFggV5uFvtRC0yuziYBL5M9VMYqqxpWL5eBHWULmnOETgooZZkBSBD5L7OgY1ZILh K7hH8QdxXCSd8Zk23mVOD887oOgWT4B9Sqyml5SWIgOGRgIL0B9d02UgBBXrYlqKuzoZ qFvtFoVU8Hxb8rI0tLPWTJRyd9eqCgQev07JIzWQRwqmd4fPvygaP4V6yVM4lNWLFTYl pHCGgPK2XBDut7xPzSe74ts86JrJgeWHVfBnnGuCREqhBqadwXL+X1lqcLdQBw5OkStc L2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736407240; x=1737012040; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=csj2V8v4onXXcENY8LDpP3CpZGTrutHjbvLRmUPW/HE=; b=Mv9kOIHgU/rBFE/9N2aWQpvJAfDbOQqPIHVKy9ZUBBoL9WrH/oJvtDwLrbuApaRp6L JmLzYguisQ4w3StVGuygW68JaiyxcRfgps5muEkpYTP80OFO3U3nOydu5d87QiOzyU3Q v7vw+FDtVxaBbcqgjYbOCEqwjfqy0ZDJL+2XlTxfW3TT+7DIe0XHuovfyrw0baFI2s5z iB723aKEeJE2pX2ikNJSZ5YlYvEhzJUNvU05oRe6Qbg+wdHs5e8/Jt43HV/oOgwQhXhb LiQp34VPK99YUN+bAIHiGRjWWcNYyZKvUmrrRWtR1H3LHUlBxva8y4sr4XKae9Sti0yM CHig== X-Gm-Message-State: AOJu0YwBSo9vfwFv2uKQrXgpjAVxsQz9MJVcbKtjzeKoAxqAbVmvR1hp Qypg0reDvY32At4x8QqUY3FMKem8Zdsx/bZGAFxhc2AxWOyUrkBFzepptmYpxkO54dXFNEmOGAY F2QUiH2wY86aDib1yh9aZgfGiN/qO4A== X-Gm-Gg: ASbGncuw2BBs8E1AeJhoCKM7xqaR00dywYDovUgyer2q/qanFSvzukHGQtNRJo3e0+b jjp5hFPE/D3kMx5zKJcI6ZZqe4yEz6ZcFvQJuhqc= X-Google-Smtp-Source: AGHT+IHz2iRQyAW3UbqRXJFQkg1mC5uuY1wZzi5kjgnsD88UxgBMjyZl7Yw0xVggUQLcDnEyRNB21M3zEHh3Rr7d3rw= X-Received: by 2002:a05:6402:50d2:b0:5d0:bcdd:ff90 with SMTP id 4fb4d7f45d1cf-5d972e00133mr4927631a12.2.1736407238352; Wed, 08 Jan 2025 23:20:38 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 9 Jan 2025 01:20:38 -0600 In-Reply-To: X-Gm-Features: AbW1kvb1vf4DF7cKS4bngS0wGvqd52uZcN0y8QgslE-ygqxbuxbqJTrUpJsV1ME X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298808 Archived-At: Gerd M=C3=B6llmann writes: > Stefan Kangas writes: > >> Severity: wishlist >> >> Gerd, how do you feel about the below change? There's no rush to make >> this change if it's inconvenient for you, but since you use IN_MY_FORK >> elsewhere, I figured that it might be okay for you here also? >> >> If it's too much trouble, let's just revisit this later. This bug >> report will serve as a reminder, if we just lave it open. >> >> diff --git a/src/igc.c b/src/igc.c >> index 079b6a90ac6..b03c64a52b8 100644 >> --- a/src/igc.c >> +++ b/src/igc.c >> @@ -76,8 +76,7 @@ >> # error "HAVE_PDUMPER required" >> #endif >> >> -#if 0 /* Not yet because that make transfer between GNU and my fork >> - painful. */ >> +#ifndef IN_MY_FORK >> #ifdef CHECK_STRUCTS >> # include "dmpstruct.h" > > No no, it's no trouble. Thanks for working on this! > > I'd even go a step further and remove the whole #if. I think it's more > useful nowadays to have the checks than to make patching easier. OK, thanks! I removed the #if on scratch/igc (commit 826491d501d). > (BTW, the contents of the #if might be out of date, not sure if we > meanwhile fix/scan additional structs.) I've now added checks for all structs that we use in "fix_*" functions (commit 76a0d739024). I kept notes to make sure I didn't miss anything, but it's not impossible that I did. I'll double-check things later. I plan to do anything passed to the "finalize_*" ones next, which should cover most of the ones we currently depend on, I think.