From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 17:03:24 +0200 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , Stefan Monnier , Emacs developers To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 17:05:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mafpN-0000Rv-Qr for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 17:05:57 +0200 Original-Received: from localhost ([::1]:36534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mafpM-0002yZ-Qm for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 11:05:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mafnD-0001Vm-OW for emacs-devel@gnu.org; Wed, 13 Oct 2021 11:03:43 -0400 Original-Received: from mail-pf1-f169.google.com ([209.85.210.169]:43702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mafn7-0004FS-Cl; Wed, 13 Oct 2021 11:03:39 -0400 Original-Received: by mail-pf1-f169.google.com with SMTP id 187so2698127pfc.10; Wed, 13 Oct 2021 08:03:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fjw/oylHObSW32fsOSgthjnlvzwe9Cwr5xrkJ9lPEXs=; b=V4wNqZu11TH7OJqeiyqK6MrZWjw39B3mLCfdgBRYXagPyNSM4sa/VfMSSDxNksbtr+ w/HDkcKHXgoIWcgbUz5ZQAv9IZVTZnBT126kebHw7r9U1dBZRK0ovXi7xzRsCmvHYEcn Xn6pzxU6oivdiqSLj75Lii585ywZFANet/X824Il3X0pF/zQOHlNvnPhi2m+gOLbrqgl imf4XMdr1ApyYO3G+hgcOad9OEw4pGCYbgMm2Kt3CGoxiNxx7fJ7UAZ8timt7EWnjjMh 7on+/uGZ0TDpipypOvpuIo1GIqhY9ystGkxst8FCuY/QDjxCCj7CEyZI97cuJCXahFhw 3w5g== X-Gm-Message-State: AOAM533eIl7QQ0Y1k4l/utEYubpd/n1tMnzJiKThsHT9sc6Gz/SN+rml acRTci7kgHkj9FT554OKez6S0OCpqTYKsoFhS5I= X-Google-Smtp-Source: ABdhPJx1FmY7kNYW1c9Ibtkzmbb09GPNRI/wK1uy10B31P3+fconEzPk48bFWNaA2YNI8qS0LH0aukh3+LRwnkZ/UYM= X-Received: by 2002:a63:4717:: with SMTP id u23mr28178390pga.359.1634137415570; Wed, 13 Oct 2021 08:03:35 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=209.85.210.169; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f169.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276915 Archived-At: Stefan Kangas writes: > Is your 'new-kbd' intended to be bug-for-bug compatible with 'kbd', or > have there been any functional changes along the way? Are you > suggesting that we could perhaps just replace 'kbd' with your new > version? (One observation is that your version still uses the cl- > functions, so it would need adjusting for subr.el.) Now I note the following comments: ;;; Tests: ;;; Note that we fail on ;;; "M-ESC" ;;; "M-" ;;; "H-" etc, ;;; But match on "H-RET" ;;; (thanks Drew Adams) Likely due to over-optimization. So I guess we could borrow ideas from your code but not use it as a drop-in replacement in its current form.