all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#74809: [PATCH] Bump version number of stream.el to use bug fix
@ 2024-12-12  2:42 Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2025-01-02  1:36 ` Stefan Kangas
  2025-01-02 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 5+ messages in thread
From: Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-12  2:42 UTC (permalink / raw)
  To: 74809; +Cc: Nicolas Petton

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hello,

In the current version of Stream.el (2.3.0), some of the generic 
functions from Seq.el do not work with streams because the streams are 
treated as lists. In the current stable version of Stream.el, streams 
are implemented as lists. Since commit 
f48552c0668c36036ebeb6a3c87269049a2e61d9, they are implemented as 
structures.

The attached patch increases the version number from 2.3.0 to 2.4.0 so 
that the bug fix is used in the stable version.

Thank you.

[-- Attachment #2: 0001-Bump-version-number-to-avoid-streams-being-treated-a.patch --]
[-- Type: text/x-patch, Size: 1191 bytes --]

From c67a6649832be7a06ea27ebc350d9cd03168b44d Mon Sep 17 00:00:00 2001
From: Earl Hyatt <okamsn@protonmail.com>
Date: Wed, 11 Dec 2024 21:15:40 -0500
Subject: [PATCH] Bump version number to avoid streams being treated as lists
 (as in bug#73431)

When streams were implemented as lists, a generic function in Seq.el would use
the method defined for lists unless there was a specific version defined for
streams in Stream.el.  Unless Stream.el was kept up to date, any specializations
or improvements for lists in Seq.el could break the implementation of the Seq.el
features for streams.

This changed in commit f48552c0668c36036ebeb6a3c87269049a2e61d9, in which
streams were changed to use cl-defstruct instead of lists.

* stream.el: Increase version number from 2.3.0 to 2.4.0 so that the bug fix is
used.
---
 stream.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stream.el b/stream.el
index dcd45a7..b90ccbf 100644
--- a/stream.el
+++ b/stream.el
@@ -4,7 +4,7 @@
 
 ;; Author: Nicolas Petton <nicolas@petton.fr>
 ;; Keywords: stream, laziness, sequences
-;; Version: 2.3.0
+;; Version: 2.4.0
 ;; Package-Requires: ((emacs "25"))
 ;; Package: stream
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#74809: [PATCH] Bump version number of stream.el to use bug fix
  2024-12-12  2:42 bug#74809: [PATCH] Bump version number of stream.el to use bug fix Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2025-01-02  1:36 ` Stefan Kangas
  2025-01-02 13:46   ` Philip Kaludercic
  2025-01-02 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2025-01-02  1:36 UTC (permalink / raw)
  To: Okamsn; +Cc: Philip Kaludercic, Nicolas Petton, 74809, Stefan Monnier

Okamsn <okamsn@protonmail.com> writes:

> Hello,
>
> In the current version of Stream.el (2.3.0), some of the generic
> functions from Seq.el do not work with streams because the streams are
> treated as lists. In the current stable version of Stream.el, streams
> are implemented as lists. Since commit
> f48552c0668c36036ebeb6a3c87269049a2e61d9, they are implemented as
> structures.
>
> The attached patch increases the version number from 2.3.0 to 2.4.0 so
> that the bug fix is used in the stable version.
>
> Thank you.

Philip, Stefan, could you please take a look at this?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#74809: [PATCH] Bump version number of stream.el to use bug fix
  2025-01-02  1:36 ` Stefan Kangas
@ 2025-01-02 13:46   ` Philip Kaludercic
  0 siblings, 0 replies; 5+ messages in thread
From: Philip Kaludercic @ 2025-01-02 13:46 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Okamsn, Nicolas Petton, 74809, Stefan Monnier

Stefan Kangas <stefankangas@gmail.com> writes:

> Okamsn <okamsn@protonmail.com> writes:
>
>> Hello,
>>
>> In the current version of Stream.el (2.3.0), some of the generic
>> functions from Seq.el do not work with streams because the streams are
>> treated as lists. In the current stable version of Stream.el, streams
>> are implemented as lists. Since commit
>> f48552c0668c36036ebeb6a3c87269049a2e61d9, they are implemented as
>> structures.
>>
>> The attached patch increases the version number from 2.3.0 to 2.4.0 so
>> that the bug fix is used in the stable version.
>>
>> Thank you.
>
> Philip, Stefan, could you please take a look at this?

Seems OK to me.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#74809: [PATCH] Bump version number of stream.el to use bug fix
  2024-12-12  2:42 bug#74809: [PATCH] Bump version number of stream.el to use bug fix Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2025-01-02  1:36 ` Stefan Kangas
@ 2025-01-02 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2025-01-02 17:28   ` Stefan Kangas
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2025-01-02 17:24 UTC (permalink / raw)
  To: Okamsn; +Cc: Nicolas Petton, 74809

> The attached patch increases the version number from 2.3.0 to 2.4.0 so 
> that the bug fix is used in the stable version.

Thanks, pushed,


        Stefan






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#74809: [PATCH] Bump version number of stream.el to use bug fix
  2025-01-02 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2025-01-02 17:28   ` Stefan Kangas
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2025-01-02 17:28 UTC (permalink / raw)
  To: Stefan Monnier, Okamsn; +Cc: Nicolas Petton, 74809-done

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

>> The attached patch increases the version number from 2.3.0 to 2.4.0 so
>> that the bug fix is used in the stable version.
>
> Thanks, pushed,

I'm therefore closing this bug report.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-01-02 17:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-12  2:42 bug#74809: [PATCH] Bump version number of stream.el to use bug fix Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-02  1:36 ` Stefan Kangas
2025-01-02 13:46   ` Philip Kaludercic
2025-01-02 17:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-02 17:28   ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.