From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode Date: Wed, 16 Aug 2023 21:45:57 +0200 Message-ID: References: <169185199333.11628.2162615922937919004@vcs2.savannah.gnu.org> <20230812145313.C853CC038C2@vcs2.savannah.gnu.org> <871qg3404x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10595"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Visuwesh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 21:46:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWMTo-0002ZM-BM for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 21:46:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWMT8-0005o6-8f; Wed, 16 Aug 2023 15:46:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWMT6-0005nP-K6 for emacs-devel@gnu.org; Wed, 16 Aug 2023 15:46:12 -0400 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWMT4-000646-Hu for emacs-devel@gnu.org; Wed, 16 Aug 2023 15:46:12 -0400 Original-Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-522dd6b6438so8681206a12.0 for ; Wed, 16 Aug 2023 12:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692215169; x=1692819969; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D718YrAwtM3Gd+ry0j9hPlM2hln3qbbzHpPENK5Q5HI=; b=MwlLgQh0ex8Uc4mfvTuWtUcYyJVSxvPTfi87kOedUUbJ+AfBdL9+1kG0cPvijq+mLH Od5UWP3rEDp/ywpszTpkPtfFE5hVmYBJBBO0nEASnsx5wch9AuhroC/BQ46q6FiUCISh YsUZcu2G/gkZ7mWGUg2nFhzkSbY63g53Dcn+BGKa9bzcaR7KZXhBR5IYDkj2tIwKkXU5 x42jKWEYw+NKkUDbSdeH4wYJYnKFlpP1ryKWbvJx7ku1ElIpyuUbt3HZcqp+rOHsXSSc nWa6lF2HYYqGz7Wm+O0YW4IR2Dp73Kdj4/kTKWVmMo7aR55tqAGNnMGTchlhuQZx9wN5 YJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692215169; x=1692819969; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D718YrAwtM3Gd+ry0j9hPlM2hln3qbbzHpPENK5Q5HI=; b=iRXwAC400bZbiZw6FHuC23zwxdzyhSsWw+3Us2BU7KAHXextobuWOYfKxKzdyhJS1T b0pqU8vNX2yCpOe+S9FYITjdq0AabKkWH/20y+yBlnta7rYMg3wAoWlXEISee0x5RZm8 ZP/6ECH4UdckN1qDJ4TRQvwx7Mo4iPR5Y/bFEjBXJji+HltqLhwrMy0CHOI48mTFof1t +PrjDDVes2E0Uten+LkJPc8i3d9+n81MwhkD5Swn/4UmtE2m7PIq7f9eA4DpLVqWUuDI LH6u8VKPBfvOrkNa6xgJ3Byb1D+bYO7d4Z4is9YraX9S5xbD2LtTlc0lQiJUikN89d7Y ec6Q== X-Gm-Message-State: AOJu0YzQAuhdamiBhNJ85a7rfJi0/LtUIPwCc9pyX6R2t2KE/uvB0mIh aAHBkqC89v9PxTryHrpIP6xuThsjp3MGRdEA+hA= X-Google-Smtp-Source: AGHT+IE7KJ4dZJajmpRBqiYCiWHRTdYcoFRUAnDM054vo+iQ8B9gQUARFbR8lHUDfb5L4vq8X7UG+0FwtqjPuOATZlI= X-Received: by 2002:aa7:d584:0:b0:51e:53eb:88a3 with SMTP id r4-20020aa7d584000000b0051e53eb88a3mr2223273edq.25.1692215168732; Wed, 16 Aug 2023 12:46:08 -0700 (PDT) In-Reply-To: <871qg3404x.fsf@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308837 Archived-At: Visuwesh writes: > I believe the following function should be faster > > (defun dictionary--count-mode-buffers () > "Return the number of buffers that " > (seq-reduce (lambda (count buf) > (if (provided-mode-derived-p (buffer-local-value 'major-mode buf) > 'dictionary-mode) > (+ count 1) > count)) > (buffer-list) > 0)) Thanks, pushed to master (commit d96dd127e39).