Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Visuwesh]

[சனி ஆகஸ்ட் 12, 2023] Stefan Kangas wrote:

> branch: master
> commit 5892b4db8de4694904f631dd86438926fb9d7ff1
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     Convert dictionary-mode to define-derived-mode
>     
>     * lisp/net/dictionary.el (dictionary-instances): Delete.
>     (dictionary-mode): Use define-derived-mode.
>     (dictionary--count-mode-buffers): New function.
>     (dictionary-close): Use above new function.
 
> +(defun dictionary--count-mode-buffers ()
> +  "Return the number of buffers that "

The docstring is incomplete here.  :-(

> +  (seq-reduce #'+
> +              (mapcar
> +               (lambda (buf)
> +                 (with-current-buffer buf
> +                   (if (derived-mode-p 'dictionary-mode) 1 0)))
> +               (buffer-list))
> +              0))
> +

I believe the following function should be faster

    (defun dictionary--count-mode-buffers ()
      "Return the number of buffers that "
      (seq-reduce (lambda (count buf)
                    (if (provided-mode-derived-p (buffer-local-value 'major-mode buf)
                                                 'dictionary-mode)
                        (+ count 1)
                      count))
                  (buffer-list)
                  0))

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Stefan Kangas]

Visuwesh <visuweshm@gmail.com> writes:

> I believe the following function should be faster
>
>     (defun dictionary--count-mode-buffers ()
>       "Return the number of buffers that "
>       (seq-reduce (lambda (count buf)
>                     (if (provided-mode-derived-p (buffer-local-value 'major-mode buf)
>                                                  'dictionary-mode)
>                         (+ count 1)
>                       count))
>                   (buffer-list)
>                   0))

Thanks, pushed to master (commit d96dd127e39).

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Philip Kaludercic]

Visuwesh <visuweshm@gmail.com> writes:

> [சனி ஆகஸ்ட் 12, 2023] Stefan Kangas wrote:
>
>> branch: master
>> commit 5892b4db8de4694904f631dd86438926fb9d7ff1
>> Author: Stefan Kangas <stefankangas@gmail.com>
>> Commit: Stefan Kangas <stefankangas@gmail.com>
>>
>>     Convert dictionary-mode to define-derived-mode
>>     
>>     * lisp/net/dictionary.el (dictionary-instances): Delete.
>>     (dictionary-mode): Use define-derived-mode.
>>     (dictionary--count-mode-buffers): New function.
>>     (dictionary-close): Use above new function.
>  
>> +(defun dictionary--count-mode-buffers ()
>> +  "Return the number of buffers that "
>
> The docstring is incomplete here.  :-(
>
>> +  (seq-reduce #'+
>> +              (mapcar
>> +               (lambda (buf)
>> +                 (with-current-buffer buf
>> +                   (if (derived-mode-p 'dictionary-mode) 1 0)))
>> +               (buffer-list))
>> +              0))
>> +
>
> I believe the following function should be faster
>
>     (defun dictionary--count-mode-buffers ()
>       "Return the number of buffers that "
>       (seq-reduce (lambda (count buf)
>                     (if (provided-mode-derived-p (buffer-local-value 'major-mode buf)
>                                                  'dictionary-mode)
>                         (+ count 1)
>                       count))
>                   (buffer-list)
>                   0))

Alternatively (length (match-buffers '(derived-mode . dictionary-mode)))

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Basil L. Contovounesios]

Visuwesh [2023-08-16 18:25 +0530] wrote:

> [சனி ஆகஸ்ட் 12, 2023] Stefan Kangas wrote:
>
>> branch: master
>> commit 5892b4db8de4694904f631dd86438926fb9d7ff1
>> Author: Stefan Kangas <stefankangas@gmail.com>
>> Commit: Stefan Kangas <stefankangas@gmail.com>
>>
>> +  (seq-reduce #'+
>> +              (mapcar
>> +               (lambda (buf)
>> +                 (with-current-buffer buf
>> +                   (if (derived-mode-p 'dictionary-mode) 1 0)))
>> +               (buffer-list))
>> +              0))
>> +
>
> I believe the following function should be faster
>
>     (defun dictionary--count-mode-buffers ()
>       "Return the number of buffers that "
>       (seq-reduce (lambda (count buf)
>                     (if (provided-mode-derived-p (buffer-local-value 'major-mode buf)
>                                                  'dictionary-mode)
>                         (+ count 1)
>                       count))
>                   (buffer-list)
>                   0))

Yet faster and simpler would be to use seq-count in place of seq-reduce.

Thanks,
-- 
Basil

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net>:

> Alternatively (length (match-buffers '(derived-mode . dictionary-mode)))

Nice golfing, thanks.  I installed that.

Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode

[Philip Kaludercic]

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net>:
>
>> Alternatively (length (match-buffers '(derived-mode . dictionary-mode)))
>
> Nice golfing, thanks.  I installed that.

Though one should note that it does cons unnecessarily.  It probably
doesn't matter that much, due to the scope of the problem, but perhaps
it would be a good idea to add an optional COUNT argument to
`match-buffer', like the one that was added to `directory-files'.