From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap. Date: Fri, 10 Dec 2021 15:37:32 +0000 Message-ID: References: <83ilvwsdxg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 10 16:39:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvhzB-0002fF-41 for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 16:39:01 +0100 Original-Received: from localhost ([::1]:47794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvhz8-0008It-4P for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 10:38:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvhxr-0006oV-FQ for emacs-devel@gnu.org; Fri, 10 Dec 2021 10:37:39 -0500 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:39744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvhxp-000210-VF; Fri, 10 Dec 2021 10:37:39 -0500 Original-Received: by mail-pl1-f181.google.com with SMTP id z6so6519084plk.6; Fri, 10 Dec 2021 07:37:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=yNs40fH2zMm/lrIpvub06cdd+MAFP+pGOV5usn99lCQ=; b=CVQBWEfkFv95eM3asPsInAm7dN/lSHAVW1PmoqIn43mnw60CiUn3MppKZ13e2LjyTZ 1FRN5X9C/kfuDBuGWpCuS2hFGV6c1Dls6FqnHHPqp4gSxTNvRsvlzLww3GDkDowMTatI NAl/RsjGKZrwN4MgiNR/XmhTKE22oAIT3pLVUSvvCSJ/G6+21feMB+czzDn6dlBNqB62 nhcSsM+Dew/eltLZXXh0bZPYmsHk6F8mG8O+9BiQzc5eH1DKIvd8gx6Erz5VBjJqQ5pF nbkw/p9pab2IAhDjLTGIH6Cz6YX/6FGmqgiUSIeUq9zfp27faACcNul8ihio/S8ZjjT6 cOEg== X-Gm-Message-State: AOAM530ZJWFRMYKCDnjTaTklcY2xjXybJ/Evc8VVm5X5D/1gd6OnNiex lS2mDY6oQs/cHb4sowTZa7DkowlIza/X0VwNtRuI/Uch X-Google-Smtp-Source: ABdhPJzE0sNSeQxSKlkJR9i5mn4R3Worbjzc+FOnj5sSp7CC2okJqLqbcR4jQAcHw0Khm+qXTQ7Mr6fiV2FMkg9RHwo= X-Received: by 2002:a17:90a:4414:: with SMTP id s20mr24972378pjg.132.1639150653300; Fri, 10 Dec 2021 07:37:33 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 10 Dec 2021 15:37:32 +0000 In-Reply-To: <83ilvwsdxg.fsf@gnu.org> Received-SPF: pass client-ip=209.85.214.181; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f181.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281604 Archived-At: Eli Zaretskii writes: >> +** Convert defvar foo-mode-map to defvar-keymap >> +Verify the conversion by comparing the value of the keymap before >> +converting it and after (you can see the value in 'C-h v'). > > Really? What are the benefits of doing such a conversion? I see only > a lot of code churn and a risk of breaking things that are perfectly > fine as they are. I think this is a good entry-level exercise for someone who is looking to start contributing to Emacs. To minimize the risk, I added the instruction that one should check the value before and after. Please feel free to revert it if you disagree. > And that goes for many of the changes in this direction you made > lately, btw: why are we making all those changes for purely stylistic > reasons? Yes, I'm not making any friends doing that, am I? :-) Personally, I do such things when I don't have the time or energy to invest in anything significant. I can come up with other ways to procrastinate, of course.