From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap.
Date: Fri, 10 Dec 2021 15:37:32 +0000 [thread overview]
Message-ID: <CADwFkmkSg1AqA6vEupSj1+gfciDR6Jd7VjPd8inJGS_2nSkLxA@mail.gmail.com> (raw)
In-Reply-To: <83ilvwsdxg.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> +** Convert defvar foo-mode-map to defvar-keymap
>> +Verify the conversion by comparing the value of the keymap before
>> +converting it and after (you can see the value in 'C-h v').
>
> Really? What are the benefits of doing such a conversion? I see only
> a lot of code churn and a risk of breaking things that are perfectly
> fine as they are.
I think this is a good entry-level exercise for someone who is looking
to start contributing to Emacs. To minimize the risk, I added the
instruction that one should check the value before and after.
Please feel free to revert it if you disagree.
> And that goes for many of the changes in this direction you made
> lately, btw: why are we making all those changes for purely stylistic
> reasons?
Yes, I'm not making any friends doing that, am I? :-)
Personally, I do such things when I don't have the time or energy to
invest in anything significant. I can come up with other ways to
procrastinate, of course.
next prev parent reply other threads:[~2021-12-10 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 15:00 master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap Eli Zaretskii
2021-12-10 15:37 ` Stefan Kangas [this message]
2021-12-10 16:51 ` Eli Zaretskii
2021-12-11 3:02 ` Lars Ingebrigtsen
2021-12-11 6:20 ` Stefan Kangas
2021-12-10 15:59 ` dick
2021-12-10 16:44 ` Alan Mackenzie
2021-12-11 0:56 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkSg1AqA6vEupSj1+gfciDR6Jd7VjPd8inJGS_2nSkLxA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.