From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62704: 30.0.50; treesit-install-language-grammar should accept an arg to indicate the installation path. Date: Mon, 11 Sep 2023 16:35:37 -0700 Message-ID: References: <4E6070E6-7491-413B-9E52-228419EC8405@gmail.com> <49AD3E51-A184-49A4-A0A0-71FB13C02A46@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: nasyxx@gmail.com, 62704-done@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 12 01:36:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfqRx-0008N6-I0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Sep 2023 01:36:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfqRk-0007dr-GB; Mon, 11 Sep 2023 19:36:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfqRi-0007dU-MK for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 19:35:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfqRi-0003wr-E7 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 19:35:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfqRm-0000FX-MZ for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 19:36:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 23:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62704 X-GNU-PR-Package: emacs Mail-Followup-To: 62704@debbugs.gnu.org, stefankangas@gmail.com, nasyxx@gmail.com Original-Received: via spool by 62704-done@debbugs.gnu.org id=D62704.1694475349925 (code D ref 62704); Mon, 11 Sep 2023 23:36:02 +0000 Original-Received: (at 62704-done) by debbugs.gnu.org; 11 Sep 2023 23:35:49 +0000 Original-Received: from localhost ([127.0.0.1]:55186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqRZ-0000Er-8g for submit@debbugs.gnu.org; Mon, 11 Sep 2023 19:35:49 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:54340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqRY-0000Ee-A1 for 62704-done@debbugs.gnu.org; Mon, 11 Sep 2023 19:35:48 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bf6b37859eso57882491fa.0 for <62704-done@debbugs.gnu.org>; Mon, 11 Sep 2023 16:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694475338; x=1695080138; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=kuGqkNZtGk3g8MUEg6af97McHTayqUPpZjALLMzshHA=; b=i+QdJck7u3cHpEyNL3zhShy0qNqT8cxk3fiVIOeIbESdaak34je9h59+9/+XLlGXfH 1uTopMtDhtl9cTKb5a0AZNer98VE4iabb9TsA5RUjd7O1bLO7j3A/5NNYSmZN/0rXueE mzRgwfllwjlP+3BpQNS1LivbpCd6YfPWVbW2fawia588ipLbEiHKnvXjpvLsI9QemYJ5 7clfNBi4X/PBkz00Lo272JjbMPee7sSNG4xqnNdr/bBKIULQcZg+hMpgtmUt/K4agrJR E7kq+72Knqif77bj00mX5iLTG2QG+aj4+OpDIkOpVk4oTOMqPqBZV37hJCtGQIboePZh 6Nqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694475338; x=1695080138; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kuGqkNZtGk3g8MUEg6af97McHTayqUPpZjALLMzshHA=; b=jt68EqS0H+hd3TmsxqIgHoJfj8sVT0eunRJhUjm15+81uxEh9k6ExhvF5bpxqxIF2v ALAzFX93vgr95dfvwZUYpRDdj3d3v0y0SFdf5CRPH9Pl+ddcfNv3gesBjTP9p+u/ySxm 2cYGAlZtpcIMHeimiW9wuB5gqu47JvNbfhPoYPPbqUzKoyGFPCpkK/ca5k+fnXQQtkzH jwnXtfn/AjQKAt/HfQ+OGlFUuEdMIggr6TsU9UrUhBVgtkbOEq6/H1FCMh+srxKMyZt2 bUtuTI3IIllEwQ/M7p5OihfNMrE3Lh1qkm3ZRCIH0OpX0RFsqdocxSrlqzkJym2H1gBG pg2g== X-Gm-Message-State: AOJu0Yw1w9jv/0KN/RK2TFMpzk8FJvMIksvUlAHO73ZsRCMjOLK2P2fS n/4Szvo3dDOC7st8cMIWTBoQLQhURYb0tPcuEztWUjIg X-Google-Smtp-Source: AGHT+IG2xzj7OHUcjiuRSpRkM6foq8Angk4H5sv/e9xiI3VwhN2YokYolquwSAhBAM32YA3QoNdKaUwjG6oq9oTEykI= X-Received: by 2002:a2e:9c50:0:b0:2ba:7b3b:4b7d with SMTP id t16-20020a2e9c50000000b002ba7b3b4b7dmr8268566ljj.17.1694475337892; Mon, 11 Sep 2023 16:35:37 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Sep 2023 16:35:37 -0700 In-Reply-To: <49AD3E51-A184-49A4-A0A0-71FB13C02A46@gmail.com> (Yuan Fu's message of "Wed, 12 Apr 2023 00:06:44 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270102 Archived-At: Yuan Fu writes: > Nasy writes: > >> Hi, >> >> In treesit.el, the ~treesit-install-language-grammar~ function installs >> the grammar to the default path of >> ~treesit--install-language-grammar-1~, which is inconvenient for users >> who want to install the grammar to a custom path. Adding an optional >> argument =3DPATH=3D to this function and changing the line below would b= e >> better. >> >> (condition-case err >> (apply #'treesit--install-language-grammar-1 >> ;; The nil is OUT-DIR. >> - (cons nil recipe)) >> + (cons PATH recipe)) >> (error > > Fair enough. I added a prompt at the end that asks for the target > directory. Please give it a try (I didn=E2=80=99t test it :-) No further comments within 5 months, so I assume that the fix worked. I'm therefore closing this bug report with this message. If this conclusion is incorrect and this is still an issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report.