From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41030: [PATCH] Make EWW respect XDG download directory by default Date: Tue, 5 May 2020 17:32:27 -0400 Message-ID: References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> <87o8r4ha42.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="57480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Philip K , 41030@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 23:34:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW5Cy-000EqR-QJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 23:34:32 +0200 Original-Received: from localhost ([::1]:45800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW5Cx-0003xI-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 17:34:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW5BW-0002xC-78 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 17:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW5BV-0003AX-Su for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 17:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW5BV-0001qK-QA for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41030-submit@debbugs.gnu.org id=B41030.15887143557026 (code B ref 41030); Tue, 05 May 2020 21:33:01 +0000 Original-Received: (at 41030) by debbugs.gnu.org; 5 May 2020 21:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:37768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW5B4-0001pF-Rn for submit@debbugs.gnu.org; Tue, 05 May 2020 17:32:35 -0400 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:43900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW5B3-0001ov-NC for 41030@debbugs.gnu.org; Tue, 05 May 2020 17:32:34 -0400 Original-Received: by mail-yb1-f172.google.com with SMTP id o198so2043176ybg.10 for <41030@debbugs.gnu.org>; Tue, 05 May 2020 14:32:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=b16vIQOP0htbo0F5CbK7uNgCuWM1tBCTyJA44onyaJc=; b=em1iwzypbtYTmvpk0FS+KyVRR+fZxvKcBeegAvonfnFSn5+OxJhNOzviYFI2IiBD9a LwmBzK8QzJEUBvnWCfE3akzryNn+cbkYls0XjmZXWPC6x+etGKvOKCUFDFEfdmsDF7JB 51V+4Vk8LDDX+e3BkegDkEhmlYn3tHypoSyOYwH1yF/j/LHiS4NrU+r8AazX+JAnT6h9 xa1X4+BYD4PJOfTh8IsJYLgiEM2PdhFRwJ9G8ePE0pe6bYIozGrJuEYY0Dm0XEruOg3v sC5c+IVenF9/glRBn9mD9tLaDVMf40BwDDsOPBy6aReTHzO6JkbEzgfCqd4D14SNYLmp SeKw== X-Gm-Message-State: AGi0PuYOSMkS0BhqZYZ0gKqYkR0IEgxt9lcL/cogGZLmfTn0dMtEj5ew aUZTbM2MBwXBjJBBjy1AzUbbyjxuZBExCcNHmnc= X-Google-Smtp-Source: APiQypJ26IjdqwKuL97xWiPuq1lpc8wnI3jFAz4DLHhRS+S7mMqc0fyCEc+Nir0mLw1WPz8A3jgG6RtS/rMIBHy0Rk0= X-Received: by 2002:a25:fc08:: with SMTP id v8mr8387910ybd.389.1588714348100; Tue, 05 May 2020 14:32:28 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 May 2020 17:32:27 -0400 In-Reply-To: <87o8r4ha42.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179772 Archived-At: "Basil L. Contovounesios" writes: >>> -(defcustom eww-download-directory "~/Downloads/" >>> +(defcustom eww-download-directory (or (xdg-user-dir "DOWNLOAD") >>> + "~/Downloads/") >> >> This makes sense conceptually. However, on my machine, evaluating >> (xdg-user-dir "DOWNLOAD") just returns $HOME. That's a worse default >> than "~/Downloads/", no? >> >> But I don't know enough about the XDG standard to propose a solution. >> Nor do I know if this is because my setup is particularly unusual. > > It sounds like it could be specific to your environment; have a look at > 'man 1 xdg-user-dirs-update'. In my use-case, I don't think I have ever touched any of this stuff. Not AFAIR, anyways. So I wonder if the suggested code would mean to never use "~/Downloads", since xdg-user-dir will always return something else? Best regards, Stefan Kangas