all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Gabriel <gabriel376@hotmail.com>, 59266@debbugs.gnu.org
Subject: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
Date: Mon, 14 Nov 2022 20:01:10 -0800	[thread overview]
Message-ID: <CADwFkmkRU0W9tu8Nh0GO7cv1oQ8kNLWDuabnHY9T8d0T4S5zAA@mail.gmail.com> (raw)
In-Reply-To: <SJ0PR06MB860939D319E6ACE888B9C3188B059@SJ0PR06MB8609.namprd06.prod.outlook.com>

Gabriel <gabriel376@hotmail.com> writes:

> From fed6c0773f152ff795115b1a6c1a7855b3b99f54 Mon Sep 17 00:00:00 2001
> From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
> Date: Mon, 14 Nov 2022 11:36:59 -0300
> Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring
>
> * lisp/faces.el (set-face-attribute): Add `flat-button' to STYLE
>   section of docstring.
> ---
>  lisp/faces.el | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 09e8110449..4088f4be8a 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -791,9 +791,8 @@ set-face-attribute
>  color of the face for 3D boxes.  STYLE specifies whether a 3D box
>  should be draw.  If STYLE is `released-button', draw a box looking
>  like a released 3D button.  If STYLE is `pressed-button' draw a box
> -that appears like a pressed button.  If STYLE is nil, the default if
> -the property list doesn't contain a style specification, draw a 2D
> -box.
> +that appears like a pressed button.  If STYLE is nil, `flat-button'
> +or omitted, draw a 2D box.

Thanks for the patch.  It copies the text from (info "(elisp)Face
Attributes") and in that sense looks good.  But shouldn't we keep the
part saying that nil is "the default if the property list doesn't
contain a style specification"?





  reply	other threads:[~2022-11-15  4:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 14:48 bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Gabriel
2022-11-15  4:01 ` Stefan Kangas [this message]
2022-11-15  5:23   ` Gabriel
2022-11-15  6:56     ` Stefan Kangas
2022-11-15 12:34 ` Eli Zaretskii
2022-11-15 22:49   ` Gabriel
2022-11-16 14:45     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkRU0W9tu8Nh0GO7cv1oQ8kNLWDuabnHY9T8d0T4S5zAA@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=59266@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.