bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Warren Lynn]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

Hi:

I am gladly surprised to find out function
shell-command-on-region
is supposed to work on rectangle selection also (with
'region-noncontiguous-p' set to t), but then disappointed to find out the
feature does not work. It has two problems:

1. As this email title says, argument 'replace' is assumed to be t no
matter what.
2. Even if I really want to replace the original selection with the
shell-command output, it still does not work. An error will be thrown in
function "cua--insert-rectangle" due to some argument type mismatch.

This feature will be very useful to me (and hopefully others too) and I
hope somebody can fix the above.

Thanks a lot.

Warren

[-- Attachment #2: Type: text/html, Size: 895 bytes --]

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Juri Linkov]

>> I am gladly surprised to find out function
>> shell-command-on-region
>> is supposed to work on rectangle selection also (with 'region-noncontiguous-p' set to t), but then
>> disappointed to find out the feature does not work. It has two problems:
>> 
>> 1. As this email title says, argument 'replace' is assumed to be t no matter what.
>> 2. Even if I really want to replace the original selection with the shell-command output, it still does not work.
>> An error will be thrown in function "cua--insert-rectangle" due to some argument type mismatch.
>> 
>> This feature will be very useful to me (and hopefully others too) and I hope somebody can fix the above.
>
> Juri, could you please look into this?  In addition to the problem
> described in the bug report, the 'region-noncontiguous-p' argument is
> not mentioned in the doc string and not in the manual.  I'd like to
> fix that for Emacs 27, please.

This is not a bug, it was implemented so in Emacs 25.
Or you'd like to fix only documentation for Emacs 27?

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Juri Linkov]

>> From: Warren Lynn <wrn.lynn@gmail.com>
>> Date: Thu, 21 May 2020 14:53:05 -0400
>> 
>> I am gladly surprised to find out function
>> shell-command-on-region
>> is supposed to work on rectangle selection also (with 'region-noncontiguous-p' set to t), but then
>> disappointed to find out the feature does not work. It has two problems:
>> 
>> 1. As this email title says, argument 'replace' is assumed to be t no matter what.
>> 2. Even if I really want to replace the original selection with the
>> shell-command output, it still does not work.
>> An error will be thrown in function "cua--insert-rectangle" due to some argument type mismatch.
>> 
>> This feature will be very useful to me (and hopefully others too) and I hope somebody can fix the above.
>
> Juri, could you please look into this?  In addition to the problem
> described in the bug report, the 'region-noncontiguous-p' argument is
> not mentioned in the doc string and not in the manual.  I'd like to
> fix that for Emacs 27, please.

Here is the docstring fix for Emacs 27:

diff --git a/lisp/simple.el b/lisp/simple.el
index 6e69f86739..69c9b68427 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3952,7 +3952,12 @@ shell-command-on-region
 
 Optional seventh arg DISPLAY-ERROR-BUFFER, if non-nil, means to
 display the error buffer if there were any errors.  When called
-interactively, this is t."
+interactively, this is t.
+
+Non-nil REGION-NONCONTIGUOUS-P means that the region is composed of
+noncontiguous pieces.  The most common example of this is a
+rectangular region, where the pieces are separated by newline
+characters."
   (interactive (let (string)
 		 (unless (mark)
 		   (user-error "The mark is not set now, so there is no region"))

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: Warren Lynn <wrn.lynn@gmail.com>,  41440@debbugs.gnu.org
> Date: Mon, 08 Jun 2020 03:35:25 +0300
> 
> > Juri, could you please look into this?  In addition to the problem
> > described in the bug report, the 'region-noncontiguous-p' argument is
> > not mentioned in the doc string and not in the manual.  I'd like to
> > fix that for Emacs 27, please.
> 
> Here is the docstring fix for Emacs 27:

LGTM, thanks.

Are you also looking into the rest of the bug report?

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Juri Linkov]

>> > Juri, could you please look into this?  In addition to the problem
>> > described in the bug report, the 'region-noncontiguous-p' argument is
>> > not mentioned in the doc string and not in the manual.  I'd like to
>> > fix that for Emacs 27, please.
>> 
>> Here is the docstring fix for Emacs 27:
>
> LGTM, thanks.

Pushed docstring fix to emacs-27.

> Are you also looking into the rest of the bug report?

The first part of the original report asks for a new feature,
now I implemented it in master in commit 3b93549597.

The second part reports a bug, but I can't reproduce it.

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: wrn.lynn@gmail.com,  41440@debbugs.gnu.org
> Date: Tue, 09 Jun 2020 02:35:53 +0300
> 
> Pushed docstring fix to emacs-27.
> 
> > Are you also looking into the rest of the bug report?
> 
> The first part of the original report asks for a new feature,
> now I implemented it in master in commit 3b93549597.
> 
> The second part reports a bug, but I can't reproduce it.

OK, thanks.

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Juri Linkov]

>> Pushed docstring fix to emacs-27.
>> 
>> > Are you also looking into the rest of the bug report?
>> 
>> The first part of the original report asks for a new feature,
>> now I implemented it in master in commit 3b93549597.
>> 
>> The second part reports a bug, but I can't reproduce it.
>
> OK, thanks.

Actually, I found where the bug was, and pushed the fix to emacs-27
in the commit 22f4fba8a9.

Now we have to wait when Warren will have time to confirm
if everything is alright.

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Stefan Kangas]

Juri Linkov <juri@linkov.net> writes:

>>> Pushed docstring fix to emacs-27.
>>>
>>> > Are you also looking into the rest of the bug report?
>>>
>>> The first part of the original report asks for a new feature,
>>> now I implemented it in master in commit 3b93549597.
>>>
>>> The second part reports a bug, but I can't reproduce it.
>>
>> OK, thanks.
>
> Actually, I found where the bug was, and pushed the fix to emacs-27
> in the commit 22f4fba8a9.
>
> Now we have to wait when Warren will have time to confirm
> if everything is alright.

Warren, did you have time to test if Juri's fix solved the problem?

If I don't hear back from you within a couple of weeks, I'll just
assume this has been fixed and close this bug.  Thanks.

Best regards,
Stefan Kangas

bug#41440: 26.3; 'replace' argument in function 'shell-command-on-region' is assumed to be always t for rectangle selection

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

>> Now we have to wait when Warren will have time to confirm
>> if everything is alright.
>
> Warren, did you have time to test if Juri's fix solved the problem?
>
> If I don't hear back from you within a couple of weeks, I'll just
> assume this has been fixed and close this bug.  Thanks.

This was five weeks ago, so I'm now closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no