From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Sat, 26 Nov 2022 01:47:25 -0800 Message-ID: References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> <83fse7ut10.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10124"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544@debbugs.gnu.org, Eli Zaretskii To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 10:48:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyrnJ-0002RR-OM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 10:48:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyrn5-0000FL-9x; Sat, 26 Nov 2022 04:48:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyrn1-0000F7-HP for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 04:48:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyrn0-00084t-Lw for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 04:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyrn0-0003NV-G9 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 04:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.166945605512843 (code B ref 59544); Sat, 26 Nov 2022 09:48:02 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 26 Nov 2022 09:47:35 +0000 Original-Received: from localhost ([127.0.0.1]:37848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrmZ-0003L5-3u for submit@debbugs.gnu.org; Sat, 26 Nov 2022 04:47:35 -0500 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:37856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrmV-0003Kr-Vl for 59544@debbugs.gnu.org; Sat, 26 Nov 2022 04:47:33 -0500 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-12c8312131fso7742306fac.4 for <59544@debbugs.gnu.org>; Sat, 26 Nov 2022 01:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=noQ0OyiwBC7liUFNUMHWrV+KAiJ/AaUxT7U508rxkZM=; b=J172LIJUoW27Zrh5CQXfI6NR7dNrMMslsUUNUkenDggUR6ujY8jkPgglVk5eo2byU8 8pwXJRut4HL8f+9qsbmrUdv6hakznPoglhogu/w1BHS3fPdagw49IF8vvzkiXsMD6Z6M M/jtEicv5giq3E4otZMpEG/xnBIs6Gm+fvEWcsTFybrI+4sPevia3SL+OfciO5rfdzLT I2BbPCB9SMGddPxg85uspy4O+XxlKzFuMZrc0sqQju9iwzuUVjS69VDX00OCHvLa/jho qdXiRhBLYl9T/Vi/gGXeWiZwT+WPKh4SUaPS1r2+hX+Vtqi4raesAvj6yDm4Ukv+MfGv ek9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=noQ0OyiwBC7liUFNUMHWrV+KAiJ/AaUxT7U508rxkZM=; b=ZZMPUvYVGY9zGLZ5yMm8BEAr89O5q3maxFDGBjYt1X7wOvI9zmD5mN5YVE0Jw2SeRK bcBe+u5iENfNCnSvZ9sGBg61zImPGKDatzMSEGMW/IKklkWi4z4ckNeOYGrQxPLK0Wpy vBJTthKBqiZApAGlFWdPKW+MFOR50qt1xRL6Lm+qmju9xf0zjThBd0bJjpj4O4UyF3LX pKy+h+fLWLOZ89PTWNFgpyu70uVakH2rsPgU/iQwEvihULUMgjuhpMw4c6YxBBLSxcgl xVVS9YIdldN95vxv8CJLtbnTS4RVeGU6wH8LWUpUlDfXXeoZvpLJEY0lxMS86vsrc6nX JlBQ== X-Gm-Message-State: ANoB5pkvAGVbXcPc/ukWry6n7jVCB7uuhd4PxCr+Bay25ZbDAa5SsPls P2yvh+CL7EILSHUkKRVdNHQQjZViTH/kUbHDXJ8= X-Google-Smtp-Source: AA0mqf64dGELatbaAqE/RymGr7fDxPyoyXUDqS4ARU+EcBF3wbx7DPaGSsu8FwvFo2p9rc4qJPfiMbcf/CMKJt4nqW0= X-Received: by 2002:a05:6870:4995:b0:143:522a:ebcc with SMTP id ho21-20020a056870499500b00143522aebccmr6769904oab.199.1669456046404; Sat, 26 Nov 2022 01:47:26 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 26 Nov 2022 01:47:25 -0800 In-Reply-To: (lux's message of "Sat, 26 Nov 2022 11:09:26 +0800") X-Hashcash: 1:20:221126:59544@debbugs.gnu.org::lwtVnANtpRXVB9b+:7Rcr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249060 Archived-At: lux writes: > =E5=9C=A8 2022/11/26 08:43, Stefan Kangas =E5=86=99=E9=81=93: > > Other than that, LGTM. > >> + char *buf =3D xmalloc (buf_len); > > The buf variable is not released after use, I added free (buf) Thanks. I think we should aim to push this security fix ASAP. Eli, any additional comments on the patch?