From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Tue, 9 Jan 2024 13:51:24 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38753"; mail-complaints-to="usenet@ciao.gmane.io" To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 68244@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 22:52:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNK1H-0009nB-BP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 22:52:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNK0u-00072t-Ia; Tue, 09 Jan 2024 16:52:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNK0s-00072f-Gn for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 16:51:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNK0p-00056u-0E for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 16:51:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNK0w-0008As-0d for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 16:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.170483710131379 (code B ref 68244); Tue, 09 Jan 2024 21:52:01 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 9 Jan 2024 21:51:41 +0000 Original-Received: from localhost ([127.0.0.1]:41168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNK0a-0008A2-J1 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 16:51:40 -0500 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:59764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNK0Y-00089j-PA for 68244@debbugs.gnu.org; Tue, 09 Jan 2024 16:51:39 -0500 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-554fe147ddeso4012223a12.3 for <68244@debbugs.gnu.org>; Tue, 09 Jan 2024 13:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704837086; x=1705441886; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=DLY4cyrAOCt8R9pgpcdcTr4WkRTuEqsTycB20cbGU5Q=; b=I5jEzmxR3Z2Kt4I9nnKuaphk109nLTCDM1NvE9D9WtCp/P0BkqruwpGeviYneSec5q 5GCeTPH8Ui+CRiAxcd1FS2W952Pml3HGByTChwbU1d2nfbPY58y+HW6O9VKW29Q4DhLn OzIDUKu11/R55rHxcmO2nXftxsMc8ED6lKdcOKq/kjEjEe7WZVBsaJtptvJOy0XmgrAW rdVmqeZuohw+qBU788kVB6jlv87HMUQEhcpvoZSfvsDF8fvqInXivXH2sDqeU7YrsC1G u3nxgGQ+0cciJ1V5wiU20Z7MpnqChkn74AnvNSwgfk8HahNFkDBJsW1skA2yZDRcGPGs ZP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704837086; x=1705441886; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DLY4cyrAOCt8R9pgpcdcTr4WkRTuEqsTycB20cbGU5Q=; b=Vs/IC7z/L3Z7Ja2ezAxhxZzTYTz+KtNvR7HgwKmaeNtc4N9We8nmokxhcReZEd7yk4 HE0+XeS3arfMBPet/lQWCISkT0jjSJTJ5T+SpZcnRP4csD/5MfYDBBoaGbDzo+wfyXB/ 7R8FzllBn2Hr6I0UM1Z9Zdntjug9s9DuNFPQg1OJ00M9Q1okmcQhMq8bl8Cfp7J+sROF rxbokCJCHp8Xl6PxEkAERFvdZbeZn3uGHKrZDhujRMTuMHfZroOBGPYDnK2vUtRXSUH3 bEZxJ7bJ5Z6jtWOn3UkdObrehJRups3fSDKESlpN7uYeehuWPdzet8fuxkI52gfZqtwh 6R3A== X-Gm-Message-State: AOJu0YxhSN9rrllMohYp7OBsgve5LdYouvYFkM3+so8G+LCswmanMQrI +RUYC26tPU8/TZ/qpRGdF8kh7TPqpgM38baKxT8= X-Google-Smtp-Source: AGHT+IExcdAFt7cTGj2RQ+LF3JZBQFHv8uCDUTt39YBFKqgpBY6qeeRcgTh5u25W76+c+i5M1QGxBrBzw/xUdOgtWsQ= X-Received: by 2002:a50:cccc:0:b0:54c:d9c5:f9ef with SMTP id b12-20020a50cccc000000b0054cd9c5f9efmr20596edj.8.1704837085663; Tue, 09 Jan 2024 13:51:25 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 13:51:24 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277664 Archived-At: Mattias Engdeg=C3=A5rd writes: > It's the hash-table's turn to be subjected to some performance > tuning. The implementation has changed very little over the years and > it's not so much a matter of a single big thing to fix as many small > ones, so the list of changes is fairly long but ever little helps. > > A working patch series can be found in the scratch/hash-table-perf > branch. Although it should all be satisfactory and an improvement on > what was before, there are a couple of details that I'd like to do > better, which is why this hasn't been merged yet: the way shared > hash_table_test structs are cached isn't very elegant, nor is the way > we deal with Qunbound in pdumper.c. Thanks, these changes make sense to me both in terms of the performance gains and the cleaner implementation. The improved usability (de-emphasizing `hash-table-size', etc.) and printed representation are certainly appreciated too. Maybe lift `hash-table-rehash-size' and `hash-table-rehash-threshold' to Lisp and mark them obsolete. The hash table implementation is complex enough for it to be worth avoiding cruft lying around.