From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#46611: Variables grep-window-height grep-scroll-output unused since Emacs 22.1? Date: Wed, 17 Feb 2021 21:19:59 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: 46611@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 06:22:03 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCblL-0005qm-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 06:22:03 +0100 Original-Received: from localhost ([::1]:53914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCblK-0004Jk-Mm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 00:22:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCbkM-0003qe-Ct for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 00:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCbkM-000672-4b for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 00:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCbkL-0004Dm-R5; Thu, 18 Feb 2021 00:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 05:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46611 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.161362560616128 (code B ref -1); Thu, 18 Feb 2021 05:21:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2021 05:20:06 +0000 Original-Received: from localhost ([127.0.0.1]:45557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCbjS-0004C4-Co for submit@debbugs.gnu.org; Thu, 18 Feb 2021 00:20:06 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCbjP-0004Bw-NZ for submit@debbugs.gnu.org; Thu, 18 Feb 2021 00:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCbjP-0003N9-IS for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 00:20:03 -0500 Original-Received: from mail-pj1-f48.google.com ([209.85.216.48]:36993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCbjN-0005bP-RN for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 00:20:03 -0500 Original-Received: by mail-pj1-f48.google.com with SMTP id t2so728675pjq.2 for ; Wed, 17 Feb 2021 21:20:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=Bptn9qRnuhcr9gcM6Vg7YwZavFNR53JrDvLa/LGNdj4=; b=pChiz+gQcFO18h5JBnoZsLq3lwOp2Di5QRPyfTStRhvxgaBJ/FN7JaWlX56Q9Du+YE 78C6mTZc6+ASEuaJUiHYuiLxwwp65zhXYKFDVS74BaBe/69GwG3jkWLs/uWyc73eZ5bC 00ki8bMk9AhrI87YBVUtSi5gWTeB+xn0fSf6XZRUVv3ifMWjrQzUOo6AvEmnJs3ATYZc uz1/y61heDKO8nAn3LYYmA4wbnQd7XIAvP1ia4wRCFaxK4fxYiy4PpbJsz9id9jtGgHj 0nfdLEf6cZYIWbm1igFA92BbzfE8jbI2Ycg9kxLcsoZ6NKV8/oizh3AxfiNGgUejg0sU cqBg== X-Gm-Message-State: AOAM532kRuFCSAE4vrK2P794uc6417Pb2dJk7WMwhqUfYQQhayyQLPYn fb/segVOY5PhTxatCfatpiyJYVFIwwE+fTbJ0fqtvmlu X-Google-Smtp-Source: ABdhPJwiO62txPOhST/CMMUIMiGahog+9POmnKJJGSVSsXG2CkjBBwVXhR+kk4Kar3taDsJIrPuysGwJeN3vutgak0M= X-Received: by 2002:a17:90a:bd84:: with SMTP id z4mr2307361pjr.179.1613625600208; Wed, 17 Feb 2021 21:20:00 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 17 Feb 2021 21:19:59 -0800 Received-SPF: pass client-ip=209.85.216.48; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f48.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200234 Archived-At: Severity: minor The new variables `grep-window-height' and `grep-scroll-output' were announced in NEWS.22: *** The new variables `grep-window-height' and `grep-scroll-output' override the corresponding compilation mode settings, for grep commands only. But if I'm not missing something, they were never actually part of Emacs 22.1, due to this commit: commit ab55f76f9ca670e3f41e4cfabeb35426f6b24fb6 Author: Stefan Monnier Date: Thu Mar 11 22:56:19 2004 +0000 (kill-grep): Move here from compile.el (grep-error, grep-hit-face, grep-error-face) (grep-mode-font-lock-keywords): New variables. (grep-regexp-alist): Simplify regexp and add `binary' case. (grep-mode): New mode. (grep-process-setup): Simplify. [...] - (if grep-window-height - (set (make-local-variable 'compilation-window-height) - grep-window-height)) - (set (make-local-variable 'compile-auto-highlight) - grep-auto-highlight) - (set (make-local-variable 'compilation-scroll-output) - grep-scroll-output) Stefan, do you remember any of this? Were they removed intentionally? Should we re-add the above lines? Or, given that no one seems to have noticed their absence in 16 years, perhaps it is better to just declare them obsolete? Or better yet, maybe we should: 1) Declare `grep-window-height' obsolete (as I'm not sure how useful it is). 2) Keep `grep-scroll-output' (it seems more useful) but change it from a boolean, and set it to the symbol 'default', which is taken to mean to just use whatever value 'compilation-scroll-output is set to. That way, we don't break existing configuration and behavior, plus we also allow for configuring this specifically, as was probably originally intended. (I don't necessarily see the use for configuring it separately for grep, but at least the existence of an option documents that the behavior can be changed and how.) Any opinions or comments here?