From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file Date: Thu, 11 Mar 2021 19:07:40 -0600 Message-ID: References: <197409406.192953.1598809591346@ichabod.co-bxl> <1898378843.430816.1599957743795@ichabod.co-bxl> <83bli9db3t.fsf@gnu.org> <1670898213.459425.1600016799389@ichabod.co-bxl> <83h7s1bmy5.fsf@gnu.org> <87363lh856.fsf@gnus.org> <1357196034.463572.1600022946152@ichabod.co-bxl> <83k0vnqwpg.fsf@gnu.org> <83d01fqusy.fsf@gnu.org> <838sc3qsvf.fsf@gnu.org> <838sc2p3tj.fsf@gnu.org> <87v9f5i3m7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29299"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dgutov@yandex.ru, rpluim@gmail.com, leungbk@mailfence.com, 43117@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 12 02:08:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKWHz-0007Y3-Bi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 02:08:27 +0100 Original-Received: from localhost ([::1]:33526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKWHy-0004Om-El for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Mar 2021 20:08:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKWHa-0003U3-Gd for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 20:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKWHa-00021D-9x for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 20:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKWHa-00084Y-5U for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 20:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 01:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43117-submit@debbugs.gnu.org id=B43117.161551126831004 (code B ref 43117); Fri, 12 Mar 2021 01:08:02 +0000 Original-Received: (at 43117) by debbugs.gnu.org; 12 Mar 2021 01:07:48 +0000 Original-Received: from localhost ([127.0.0.1]:55520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKWHM-00083u-3j for submit@debbugs.gnu.org; Thu, 11 Mar 2021 20:07:48 -0500 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:36749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKWHK-00083T-MP for 43117@debbugs.gnu.org; Thu, 11 Mar 2021 20:07:47 -0500 Original-Received: by mail-pj1-f46.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so9950669pjh.1 for <43117@debbugs.gnu.org>; Thu, 11 Mar 2021 17:07:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=EY1lma0dAQCftfXSfYCAo7buQn9K7sWo3QjeMp9r+OU=; b=ppiFuPHl7WtehrjjmKV2BzNvqqiUq/ROxcabiNtaEgFi9QCHjZsAAkn/Kti69Ct5pa wRiTpjhJ5klnhR2SjZNPrAuNoBWSZlAXE3xtRXlEtYUExRbRi20GFq3KUH6As1cptRpQ vt1GG/BvQp1UMrL7hzHpBgAIqMlmqcwQpbVukOU3KH5UFTN2g2jOwxhIqUEviyyhUqHj +ixnEN0Cvm9FLFgSUvUPoAIWOUOJgNCJDRVPAB0sLXtOn4fhLKTZvn3mAMbbQM3S/lWP 6b3UcETVrFCSN2cdgxW0sDj1Gr3WEP0vLqIeJjiomca5T2kXw2mlHZsq1hLrx/0MNcik waoQ== X-Gm-Message-State: AOAM533THG4uTdLr8MCgMujgK2nOYW6zyiNb8BorCGC4DUTgQLWD6b0J fof877bPWHniUlhaLhSOsUinSDfS/C7399z3CeClLMmULuE= X-Google-Smtp-Source: ABdhPJz1I45AvCFlRXg7YBITZWsKwELbUoWpKnVJa726RnAvioMCpnGvH479g7121ZHessMExCb/EnRqH9UgUnb5jpo= X-Received: by 2002:a17:90a:bd09:: with SMTP id y9mr11354049pjr.179.1615511261177; Thu, 11 Mar 2021 17:07:41 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Mar 2021 19:07:40 -0600 In-Reply-To: (Stefan Kangas's message of "Tue, 20 Oct 2020 08:05:52 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202117 Archived-At: tags 43117 + wontfix close 43117 thanks Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> Eli Zaretskii writes: >> >>>> For example, if a commit fixed a typo in a doc string, I'd much rather >>>> see the commit that added that text than the one that fixed the typo. >> >> I think I'd want commits like that included in git blame... >> >>> In short, the more I think about this feature, the less it makes sense >>> to me to use it in our project. It's probably fine for a >>> single-developer projects, where the preferences are never in >>> conflict. But ours is a very different project. >> >> If Emacs was a project that did extensive "janitorial" fixups, then it >> might make more sense. For instance, if we were to fix all whitespace >> to be consistent, then having a way to ignore that would be nice. But >> we don't, so I'm not sure adding a .git-blame-ignore-revs file helps us >> much. >> >> The only thing I'd want to use such a file for would be for things that >> really are 100% non-functional: Whitespace changes and spelling fixes >> for comments. >> >> So I don't think such a file would help the Emacs project. > > You both make good points. > > I guess the logical conclusion here is to close this bug as wontfix. No further comments within 20 weeks, so I'm closing this as wontfix.