From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#34489: 25.2; pdb fails if directory contains '++' Date: Tue, 2 Jul 2019 21:42:31 +0200 Message-ID: References: <87r2c94flq.fsf@sipc87.si.ehu.es> <835zonf2xh.fsf@gnu.org> <831rz8e6mw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ba8711058cb7f252" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187151"; mail-complaints-to="usenet@blaine.gmane.org" Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 21:55:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiOsL-000mGn-EF for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 21:55:37 +0200 Original-Received: from localhost ([::1]:56720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiOhE-0007Pz-Ty for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 15:44:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43104) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiOgH-0007NR-2S for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 15:43:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiOgE-00052p-G7 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 15:43:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiOgA-0004yI-FV for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 15:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiOgA-0006wQ-D3 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 15:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34489-submit@debbugs.gnu.org id=B34489.156209657226666 (code B ref 34489); Tue, 02 Jul 2019 19:43:02 +0000 Original-Received: (at 34489) by debbugs.gnu.org; 2 Jul 2019 19:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:47992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiOfz-0006w2-R1 for submit@debbugs.gnu.org; Tue, 02 Jul 2019 15:42:52 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:53028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiOfw-0006vo-JG for 34489@debbugs.gnu.org; Tue, 02 Jul 2019 15:42:49 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id s3so1990492wms.2 for <34489@debbugs.gnu.org>; Tue, 02 Jul 2019 12:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8PsES62oLVp8w7BUkcqN9UKC3fHamSYMAaiV99SpCmQ=; b=ERy5OeEBIuQHFTtEP5tvOvkZTbr7ebRvOE+EX5FY2AKE7M4ffy/Mc5NzG+3TOd3zno zxzTXPGSR3ZMk3Br+vEIviqUoBeurO0kwQZfwNCd3oywbhNEz3NmgYGqZ0/56nWvrT2/ 371G12sncgi6hIBzLuPiRAfsGXgmuxufScPCRej12uNKRQxdr635pw+D2HPuBwY59w1a FoJC+odWmegXbrml432C5pmPS4SZH2U9mMCJXMSbIhCUOz/3va1uXYihLAwJhibSbsI9 Lc48xZslS6bGinB0gX5eKdpesfhJIEjvHozpEZhMM5C31uKETMKvbsHYY12cP8AIT/M1 /zBw== X-Gm-Message-State: APjAAAUi/V8RK/mmMe6vdAgM5Gu1SdtF1izWJNc0NFMH3olzcQiGv/FV DqDDHkGSiFiFx2h2twRGi5iacy2T9Xi5Npe5bWM= X-Google-Smtp-Source: APXvYqz6dgsrUZ7WlvYOeM8kLZu9xhtYoZY3ZO+Z5oFNvrJ7biCZXldyRNEFPfGXTM/YkoLiEFLtrJwmSaGozMPKkQA= X-Received: by 2002:a1c:b6d4:: with SMTP id g203mr4429479wmf.19.1562096562754; Tue, 02 Jul 2019 12:42:42 -0700 (PDT) In-Reply-To: <831rz8e6mw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161979 Archived-At: --000000000000ba8711058cb7f252 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Hmm... I wonder why the code bothers specifying the allowed characters > explicitly, and in particular why it only allows ASCII characters. > > Does the code work if the directory has non-ASCII characters instead > of "++"? No, it breaks. For now, I've attached a patch to use "[:alnum:]", which fixes that use case for me. Regarding your first question, I'm not exactly sure why. Maybe we could go as far as just doing "[[:print:]]*" for that part - or simply ".*". What do you think? Thanks, Stefan Kangas --000000000000ba8711058cb7f252 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-M-x-pdb-handle-more-valid-file-names.patch" Content-Disposition: attachment; filename="0001-Make-M-x-pdb-handle-more-valid-file-names.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxm7xwrc0 RnJvbSAyZjY3MWQ3ZTg0MTA5YWY2NDk0NTdjZjA3N2NhMTBlOTQ5YzUyMTFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDMwIEp1biAyMDE5IDE5OjE3OjUyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g TWFrZSAiTS14IHBkYiIgaGFuZGxlIG1vcmUgdmFsaWQgZmlsZSBuYW1lcwoKKiBsaXNwL3Byb2dt b2Rlcy9ndWQuZWwgKGd1ZC1wZGItbWFya2VyLXJlZ2V4cCk6IEFkZCAiKyIgYW5kCiJbOmFsbnVt Ol0iIHRvIHRoZSByZWdleHAuICAoQnVnIzM0NDg5KQotLS0KIGxpc3AvcHJvZ21vZGVzL2d1ZC5l bCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2d1ZC5lbCBiL2xpc3AvcHJvZ21vZGVzL2d1ZC5l bAppbmRleCA0MzA2ZjVkYWEwLi5mZGY1M2ZmMmU3IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl cy9ndWQuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZ3VkLmVsCkBAIC0xNjA2LDcgKzE2MDYsNyBA QCBndWQtcGRiLWhpc3RvcnkKIDs7IExhc3QgZ3JvdXAgaXMgZm9yIHJldHVybiB2YWx1ZSwgZS5n LiAiPiB0ZXN0LnB5KDIpZm9vKCktPk5vbmUiCiA7OyBFaXRoZXIgZmlsZSBvciBmdW5jdGlvbiBu YW1lIG1heSBiZSBvbWl0dGVkOiAiPiA8c3RyaW5nPigwKT8oKSIKIChkZWZ2YXIgZ3VkLXBkYi1t YXJrZXItcmVnZXhwCi0gICJePiBcXChbLWEtekEtWjAtOV8vLjpAIFxcXSpcXHw8c3RyaW5nPlxc KShcXChbMC05XStcXCkpXFwoW2EtekEtWjAtOV9dKlxcfFxcP1xcfDxtb2R1bGU+XFwpKClcXCgt PlteXG5ccl0qXFwpP1tcblxyXSIpCisgICJePiBcXChbLVs6YWxudW06XV8rLy46QCBcXF0qXFx8 PHN0cmluZz5cXCkoXFwoWzAtOV0rXFwpKVxcKFthLXpBLVowLTlfXSpcXHxcXD9cXHw8bW9kdWxl PlxcKSgpXFwoLT5bXlxuXHJdKlxcKT9bXG5ccl0iKQogCiAoZGVmdmFyIGd1ZC1wZGItbWFya2Vy LXJlZ2V4cC1maWxlLWdyb3VwIDEpCiAoZGVmdmFyIGd1ZC1wZGItbWFya2VyLXJlZ2V4cC1saW5l LWdyb3VwIDIpCi0tIAoyLjExLjAKCg== --000000000000ba8711058cb7f252--