From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: a.soroa@ehu.eus, 34489@debbugs.gnu.org
Subject: bug#34489: 25.2; pdb fails if directory contains '++'
Date: Tue, 2 Jul 2019 21:42:31 +0200 [thread overview]
Message-ID: <CADwFkmkGZkqyhqDoDRrA9pXXy1OxrhQgP6=pS68JHe30__6frQ@mail.gmail.com> (raw)
In-Reply-To: <831rz8e6mw.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Hmm... I wonder why the code bothers specifying the allowed characters
> explicitly, and in particular why it only allows ASCII characters.
>
> Does the code work if the directory has non-ASCII characters instead
> of "++"?
No, it breaks. For now, I've attached a patch to use "[:alnum:]",
which fixes that use case for me.
Regarding your first question, I'm not exactly sure why. Maybe we
could go as far as just doing "[[:print:]]*" for that part - or
simply ".*". What do you think?
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Make-M-x-pdb-handle-more-valid-file-names.patch --]
[-- Type: text/x-patch, Size: 1105 bytes --]
From 2f671d7e84109af649457cf077ca10e949c5211d Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 30 Jun 2019 19:17:52 +0200
Subject: [PATCH] Make "M-x pdb" handle more valid file names
* lisp/progmodes/gud.el (gud-pdb-marker-regexp): Add "+" and
"[:alnum:]" to the regexp. (Bug#34489)
---
lisp/progmodes/gud.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index 4306f5daa0..fdf53ff2e7 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -1606,7 +1606,7 @@ gud-pdb-history
;; Last group is for return value, e.g. "> test.py(2)foo()->None"
;; Either file or function name may be omitted: "> <string>(0)?()"
(defvar gud-pdb-marker-regexp
- "^> \\([-a-zA-Z0-9_/.:@ \\]*\\|<string>\\)(\\([0-9]+\\))\\([a-zA-Z0-9_]*\\|\\?\\|<module>\\)()\\(->[^\n\r]*\\)?[\n\r]")
+ "^> \\([-[:alnum:]_+/.:@ \\]*\\|<string>\\)(\\([0-9]+\\))\\([a-zA-Z0-9_]*\\|\\?\\|<module>\\)()\\(->[^\n\r]*\\)?[\n\r]")
(defvar gud-pdb-marker-regexp-file-group 1)
(defvar gud-pdb-marker-regexp-line-group 2)
--
2.11.0
next prev parent reply other threads:[~2019-07-02 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 8:32 bug#34489: 25.2; pdb fails if directory contains '++' a.soroa
2019-06-30 16:13 ` Stefan Kangas
2019-06-30 16:33 ` Eli Zaretskii
2019-06-30 17:24 ` Stefan Kangas
2019-07-02 16:35 ` Eli Zaretskii
2019-07-02 19:42 ` Stefan Kangas [this message]
2019-07-03 5:39 ` Eli Zaretskii
2019-07-05 15:51 ` Stefan Kangas
2019-07-06 9:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkGZkqyhqDoDRrA9pXXy1OxrhQgP6=pS68JHe30__6frQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=34489@debbugs.gnu.org \
--cc=a.soroa@ehu.eus \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.