all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Juri Linkov <juri@linkov.net>
Cc: 51451@debbugs.gnu.org
Subject: bug#51451: image-transform-original has a misleading name
Date: Wed, 3 Nov 2021 13:16:55 -0700	[thread overview]
Message-ID: <CADwFkmkFpaA468jz4r30THACyhGxn+taTvb_kjbgUb5zF2zE7g@mail.gmail.com> (raw)
In-Reply-To: <86ee7xvzwi.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should.  Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.

That's true.

> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.

I see a problem with all of them, especially in combination with
`image-save'.  :-(

But the most confusing one by far is `image-transform-original', indeed.





  reply	other threads:[~2021-11-03 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  0:31 bug#51451: image-transform-original has a misleading name Stefan Kangas
2021-10-29 13:14 ` Lars Ingebrigtsen
     [not found] ` <87ilxdnsbu.fsf@mail.linkov.net>
2021-10-31 20:24   ` Stefan Kangas
2021-11-03 18:48     ` Juri Linkov
2021-11-03 20:16       ` Stefan Kangas [this message]
2022-09-14 13:52       ` Stefan Kangas
2022-09-14 19:11         ` Juri Linkov
2022-09-14 23:06           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkFpaA468jz4r30THACyhGxn+taTvb_kjbgUb5zF2zE7g@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=51451@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.