From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#72245: [PATCH] Fix integer overflow when reading XPM Date: Mon, 22 Jul 2024 21:12:44 -0700 Message-ID: References: <87frs0ydv6.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1930"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72245@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 06:14:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sW6un-0000Po-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 06:14:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sW6uW-0004PD-4C; Tue, 23 Jul 2024 00:14:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sW6uU-0004P0-ME for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 00:13:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sW6uU-0000YU-DA for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 00:13:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sW6uY-0000sb-15 for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 00:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 04:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72245-submit@debbugs.gnu.org id=B72245.17217080383365 (code B ref 72245); Tue, 23 Jul 2024 04:14:01 +0000 Original-Received: (at 72245) by debbugs.gnu.org; 23 Jul 2024 04:13:58 +0000 Original-Received: from localhost ([127.0.0.1]:58930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW6uU-0000sD-3j for submit@debbugs.gnu.org; Tue, 23 Jul 2024 00:13:58 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:54287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW6uR-0000rz-DK for 72245@debbugs.gnu.org; Tue, 23 Jul 2024 00:13:56 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5a108354819so4620473a12.0 for <72245@debbugs.gnu.org>; Mon, 22 Jul 2024 21:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721707965; x=1722312765; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=aiuCeJ0GeiQ3zbD/zHYbheIQ8c1tRu1rGChO3bgxM10=; b=OfxrI4Sh9CYBYMOgByginYRQVvBVQ8mpjtlY3+bRSW46U0izkAUtSNqo/a9Uar+V8g E6jx2pY6JeNFuWs0Fh9ll5Wc4dHl65OtzEs5FUB7KmA1DxB4da3xMB2d4PYetQ0BqGuy dzDKCl/SNSQmLELDPff2uwq3V2PGgz3TI49uQ8cHsYkC7tm0vbQVbRUJKSi0AzfdA30I HDAU0Q/d3HkCo/JyL8cukXqgHnETdW0BlMka3dVwXlOSzo50ka18xnmbJBsOuznvpJxV WfKLc0v0r2wDR6muQnBi70v+ozq4BKMPwbJCjVMjc+0MVx/amn2torVYbr18E0rxYR/K kmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721707965; x=1722312765; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aiuCeJ0GeiQ3zbD/zHYbheIQ8c1tRu1rGChO3bgxM10=; b=fREYnx0f8oxO2auxoalw2PC6W/8sPM16bgAQ9R0MXxkik2mIuz2rVFQJBz4cg5gpaA OBRzAjmySd8t7+lzF45Wg9LzDbgqg7RdFNLvAOvJisnZEddUONl4Rc24xR97P1+vvs33 vDfOa6icCCm2Mumea3KDYjYL8shf9hKC2ujqd9FeBsQTp7iVnOKrehHqkfBDnlNiXzAK pAuSwtc6KPLhmPNIz1cidik/SIH6dYqWLRxSgRMGEFXKx5mdNGbIIxqB6ELDS8o30QNS UXE2ithsleuhbF9R2dC15sFSHCN825IoMGlLLxVhBNQ9P0kvGqgnReEgsCbKdfJ0Wm8P dYfQ== X-Gm-Message-State: AOJu0Yw4aANDgBvYjzkMpQ9XE4CG3hyPElLIhxDZFyMloVpBNoIiDTGQ g0AtbkP2P/F6IYOVl8Y3Wx/cmLeFg3r/CBFlqQAfODzfOzteZF6noPSyWn6gFgRkz+aePq8dlT7 6kK9yzTtfqIEyKkW0izhbXfJ6vEA= X-Google-Smtp-Source: AGHT+IGwsZPQAt07hW34mMK5ks64BWCMST9RXji3osGva6uwR0pgSK8ixx2IrpUt3j1HrHjSQCAhdhtBlRPENLOha3o= X-Received: by 2002:a05:6402:11cf:b0:5a2:eab0:4a with SMTP id 4fb4d7f45d1cf-5a479b70b58mr6642904a12.24.1721707965409; Mon, 22 Jul 2024 21:12:45 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 22 Jul 2024 21:12:44 -0700 In-Reply-To: <87frs0ydv6.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289138 Archived-At: Po Lu writes: > Otherwise I can find no reason to substantially reinvent the wheel and > complicate image.c with a pedantic 10-line function for reading > numbers with overflow checking, implementations of which already > abound in that file in one shape or another. Thanks, but this diatribe doesn't really help. If you think you can do a better job, then fine by me. Please show us the patch.