all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode)
@ 2017-07-05  2:11 Drew Adams
  2019-08-27  1:39 ` Stefan Kangas
  0 siblings, 1 reply; 5+ messages in thread
From: Drew Adams @ 2017-07-05  2:11 UTC (permalink / raw)
  To: 27583

Most of the places where `major-mode' is tested use a test like this:
(derived-mode-p 'Info-mode).  But there are still a few places where
this is done: (eq major-mode 'Info-mode).

I think (but am not positive) that each of the latter tests should be
changed to use `derived-mode-p', to let users and libraries define and
use modes that are derived from `Info-mode'.

It looks like the places that still use (eq major-mode 'Info-mode)
constitute code that doesn't get much love.  The occurrences are in
these 3 things:

 Info-hide-note-references (in the option's :set function)
 info-display-manual
 info--manual-names (used only by info-display-manual)



In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-07 22:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05  2:11 bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Drew Adams
2019-08-27  1:39 ` Stefan Kangas
2019-08-27  2:33   ` Drew Adams
2019-09-03 18:23     ` Stefan Kangas
2019-09-07 22:20       ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.