From: Stefan Kangas <stefan@marxist.se>
To: Drew Adams <drew.adams@oracle.com>
Cc: 27583@debbugs.gnu.org
Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode)
Date: Tue, 27 Aug 2019 03:39:32 +0200 [thread overview]
Message-ID: <CADwFkmkBdNteKcNJ5BFkBkxzr90K=S=gciONu-m7__bbViwztA@mail.gmail.com> (raw)
In-Reply-To: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
tags 27583 + patch
quit
Drew Adams <drew.adams@oracle.com> writes:
> Most of the places where `major-mode' is tested use a test like this:
> (derived-mode-p 'Info-mode). But there are still a few places where
> this is done: (eq major-mode 'Info-mode).
>
> I think (but am not positive) that each of the latter tests should be
> changed to use `derived-mode-p', to let users and libraries define and
> use modes that are derived from `Info-mode'.
>
> It looks like the places that still use (eq major-mode 'Info-mode)
> constitute code that doesn't get much love. The occurrences are in
> these 3 things:
>
> Info-hide-note-references (in the option's :set function)
> info-display-manual
> info--manual-names (used only by info-display-manual)
Makes sense. How about the attached patch?
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Use-derived-mode-p-consistently-in-info.el.patch --]
[-- Type: text/x-patch, Size: 1447 bytes --]
From ad638cb9787c42d4c8a25337fb7843e0fdea6e74 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 27 Aug 2019 03:36:05 +0200
Subject: [PATCH] Use derived-mode-p consistently in info.el
* lisp/info.el (Info-hide-note-references, info-display-manual)
(info--manual-names): Use derived-mode-p. (Bug#27583)
---
lisp/info.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/info.el b/lisp/info.el
index 17a2d63e6d..bcfaddcf5a 100644
--- a/lisp/info.el
+++ b/lisp/info.el
@@ -318,7 +318,7 @@ Info-hide-note-references
(set sym val)
(dolist (buffer (buffer-list))
(with-current-buffer buffer
- (when (eq major-mode 'Info-mode)
+ (when (derived-mode-p 'Info-mode)
(revert-buffer t t)))))
:group 'info)
@@ -5300,7 +5300,7 @@ info-display-manual
found)
(dolist (buffer blist)
(with-current-buffer buffer
- (when (and (eq major-mode 'Info-mode)
+ (when (and (derived-mode-p 'Info-mode)
(stringp Info-current-file)
(string-match manual-re Info-current-file))
(setq found buffer
@@ -5315,7 +5315,7 @@ info--manual-names
(let (names)
(dolist (buffer (buffer-list))
(with-current-buffer buffer
- (and (eq major-mode 'Info-mode)
+ (and (derived-mode-p 'Info-mode)
(stringp Info-current-file)
(not (string= (substring (buffer-name) 0 1) " "))
(push (file-name-sans-extension
--
2.20.1
next prev parent reply other threads:[~2019-08-27 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 2:11 bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Drew Adams
2019-08-27 1:39 ` Stefan Kangas [this message]
2019-08-27 2:33 ` Drew Adams
2019-09-03 18:23 ` Stefan Kangas
2019-09-07 22:20 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkBdNteKcNJ5BFkBkxzr90K=S=gciONu-m7__bbViwztA@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=27583@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.