bug#44377: 28.0.50; describe-bindings; wrong-type-argument

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Achilles]

Command works almost normal(ordering looks weird) with text, prog mode
etc. Returns an error with ibuffer, gnus and perhaps with others as
well..

After bisecting the last month or so, i found:

8a1441310aa151e739cfed3bd2eff3358edc8001 is the first bad commit
commit 8a1441310aa151e739cfed3bd2eff3358edc8001
Author: Stefan Kangas <stefan@marxist.se>
Date:   Sun Oct 18 15:32:22 2020 +0200

    Prefer Lisp version of describe-map-tree

    This is a prerequisite to remove the old C functions, and gives a
    measured 3 ms slowdown on my machine, from 0.27s to 0.30s per call to
    describe-buffer-bindings (average over 50 calls).

    * src/keymap.c (Fdescribe_buffer_bindings): Call Lisp function
    describe-map-tree instead of C function describe_map_tree.

 src/keymap.c | 89 ++++++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 63 insertions(+), 26 deletions(-)


Debugger entered--Lisp error: (wrong-type-argument listp ibuffer-visit-buffer-1-window)
  describe-map-tree((keymap #^[nil nil keymap 
#^^[3 0 set-mark-command move-beginning-of-line backward-char mode-specific-command-prefix delete-char move-end-of-line forward-char keyboard-quit help-command indent-for-tab-command electric-newline-and-maybe-indent kill-line recenter-top-bottom ...] #^^[1 0 #^^[2 0 
#^^[3 0 set-mark-command move-beginning-of-line backward-char mode-specific-command-prefix delete-char move-end-of-line forward-char keyboard-quit help-command indent-for-tab-command electric-newline-and-maybe-indent kill-line recenter-top-bottom ...] self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command ...] self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command ...] self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command self-insert-command ...] ... ... ... ... ... ... ... ... ... ... ... ... ...) t (...) nil "\f\nGlobal Bindi..." t nil t nil)
  describe-buffer-bindings(#<buffer *Ibuffer*> nil)
  describe-bindings()
  funcall-interactively(describe-bindings)
  call-interactively(describe-bindings nil nil)
  command-execute(describe-bindings)


In GNU Emacs 28.0.50 (build 20, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.17.3)
 of 2020-11-01 built on computer
Repository revision: ce1856ec09dd312667d8f7cf9ffc908b473d27b8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr/local/'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: IBuffer

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-fns radix-tree cl-print debug backtrace
find-func iso-transl help-mode easymenu cl-loaddefs cl-lib ibuf-ext
ibuffer ibuffer-loaddefs seq byte-opt gv bytecomp byte-compile cconv
cus-start cus-load tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 73166 6242)
 (symbols 48 8375 1)
 (strings 32 23163 1978)
 (string-bytes 1 729977)
 (vectors 16 14142)
 (vector-slots 8 185624 8177)
 (floats 8 26 29)
 (intervals 56 407 0)
 (buffers 992 13))

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Basil L. Contovounesios]

Is this the same issue as https://debbugs.gnu.org/44360?

Thanks,

-- 
Basil

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Achilles]

>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:

    Basil> Is this the same issue as https://debbugs.gnu.org/44360?

Looks like it is.


             Achilles

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Stefan Kangas]

Achilles <ayy@posteo.is> writes:

> Command works almost normal(ordering looks weird) with text, prog mode
> etc. Returns an error with ibuffer, gnus and perhaps with others as
> well..

Thank you for the bug report.

I believe I can reproduce this using the following recipe:

0. emacs -Q
1. M-x ibuffer RET
2. C-h b

Are those the same steps that you used?

Also, could you please explain what you mean by "ordering looks weird"?
Are you seeing any changes from what you expect?  Please try to be as
specific as possible.

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Stefan Kangas]

merge 44360 44377
thanks

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Is this the same issue as https://debbugs.gnu.org/44360?

Yes, it looks like the same bug.  I'm therefore merging them now.

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Stefan Kangas]

Stefan Kangas <stefankangas@gmail.com> writes:

> Are those the same steps that you used?

Never mind that question:

I have now pushed a fix to master (commit 5ab5504def).  Could you please
test that it works for you?

> Also, could you please explain what you mean by "ordering looks weird"?
> Are you seeing any changes from what you expect?  Please try to be as
> specific as possible.

If you could elaborate on this part, that would be helpful.  Preferably
in a new bug report.

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Achilles]

>>>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:

    SK> I believe I can reproduce this using the following recipe:

    SK> 0. emacs -Q 1. M-x ibuffer RET 2. C-h b

    SK> Are those the same steps that you used?

0. Yes.
1. You can try with gnus instead of ibuffer, same result.
2. C-h b, <f1> b, M-x describe-bindings.

    SK> Also, could you please explain what you mean by "ordering looks
    SK> weird"?  Are you seeing any changes from what you expect?
    SK> Please try to be as specific as possible.

Ignore what i said earlier. If you are seeing "Key translations:" line
first and it is expected, then it's all good.


             Achilles

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Achilles]

>>>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:

    SK> I have now pushed a fix to master (commit 5ab5504def).  Could
    SK> you please test that it works for you?

It works after 5ab5504def. Thank you.


             Achilles

bug#44377: 28.0.50; describe-bindings; wrong-type-argument

[Stefan Kangas]

Achilles <ayy@posteo.is> writes:

>     SK> I have now pushed a fix to master (commit 5ab5504def).  Could
>     SK> you please test that it works for you?
>
> It works after 5ab5504def. Thank you.

Thank you for testing!  I'm therefore closing this bug.