From: Stefan Kangas <stefan@marxist.se>
To: Alan Third <alan@idiocy.org>
Cc: John Wiegley <johnw@gnu.org>, 39724@debbugs.gnu.org
Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS
Date: Mon, 24 Aug 2020 04:36:42 -0400 [thread overview]
Message-ID: <CADwFkmk8sxZa2W1mNySzhpdkKn3-9gDz2Gs=MZ3fS9gcDMakcQ@mail.gmail.com> (raw)
In-Reply-To: <20200305172208.GC56782@breton.holly.idiocy.org> (Alan Third's message of "Thu, 5 Mar 2020 18:22:10 +0100 (CET)")
Alan Third <alan@idiocy.org> writes:
> On Tue, Feb 25, 2020 at 10:06:33PM +0100, Alan Third wrote:
>> On Mon, Feb 24, 2020 at 09:56:04AM -0800, John Wiegley wrote:
>> > >>>>> "AT" == Alan Third <alan@idiocy.org> writes:
>> >
>> > AT> Are you still using Nix to build Emacs? As I recall it used to use the
>> > AT> 10.10 build environment even on more modern versions of macOS, so this
>> > AT> could still be an incompatibility between the new drawing code and older
>> > AT> versions of macOS/XCode.
>> >
>> > I am using Nix, but it passes this:
>> >
>> > -DMAC_OS_X_VERSION_MAX_ALLOWED=101200
>> >
>> > Which should be recent enough, I'd think.
>> >
>> > I also need to track down the slowness that I'm seeing, to see which commit
>> > introduced that. It will take me a few days to gather all of this information,
>> > given how slow the test cycles are.
>>
>> Could you try the below patch to see if that sorts the background issue?
>>
>> modified src/nsterm.m
>> @@ -8240,6 +8240,8 @@ - (void)createDrawingBuffer
>> /* This fixes the scale to match the backing scale factor, and flips the image. */
>> CGContextTranslateCTM(drawingBuffer, 0, NSHeight (frame) * scale);
>> CGContextScaleCTM(drawingBuffer, scale, -scale);
>> +
>> + ns_clear_frame (emacsframe);
>> }
>>
>>
>> @@ -8269,7 +8271,6 @@ - (void)windowDidChangeBackingProperties:(NSNotification *)notification
>> {
>> NSRect frame = [self frame];
>> [self createDrawingBuffer];
>> - ns_clear_frame (emacsframe);
>> expose_frame (emacsframe, 0, 0, NSWidth (frame), NSHeight (frame));
>> }
>> }
>>
>>
>> I don’t know if I’ve just missed it (I’ve been messing with my email
>> set‐up recently) but I’ve not seen the build log you promised.
>>
>
> Hi John, I don’t know if you tried the above patch, but can you please
> try building the master branch again? I fixed an issue last night that
> may be the same as your problem. I’m not sure because it all depends
> on the build environment and what versions of Cocoa are available and
> so on, and I think Nix may confuse matters.
That was 6 months ago. Any updates here?
If I don't hear back from you within a couple of weeks, I'll just
assume this has been fixed and close this bug.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-08-24 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:45 bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS John Wiegley
2020-02-21 22:50 ` Alan Third
2020-02-23 20:59 ` John Wiegley
2020-02-24 9:45 ` Alan Third
2020-02-24 17:56 ` John Wiegley
2020-02-25 21:06 ` Alan Third
2020-03-05 17:22 ` Alan Third
2020-08-24 8:36 ` Stefan Kangas [this message]
2020-10-01 12:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmk8sxZa2W1mNySzhpdkKn3-9gDz2Gs=MZ3fS9gcDMakcQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=39724@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.