From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus Date: Thu, 28 Oct 2021 00:27:18 -0700 Message-ID: References: <83v91htz4d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51446@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 28 09:28:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfzpb-0003Hf-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 09:28:11 +0200 Original-Received: from localhost ([::1]:54078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfzpZ-0004g8-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 03:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfzpS-0004g0-9b for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 03:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfzpR-0004rs-UO for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 03:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfzpR-0002P5-Mt for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 03:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2021 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51446-submit@debbugs.gnu.org id=B51446.16354060469183 (code B ref 51446); Thu, 28 Oct 2021 07:28:01 +0000 Original-Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 07:27:26 +0000 Original-Received: from localhost ([127.0.0.1]:51227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzor-0002O3-Ra for submit@debbugs.gnu.org; Thu, 28 Oct 2021 03:27:26 -0400 Original-Received: from mail-pg1-f172.google.com ([209.85.215.172]:44959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzoq-0002No-5h for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 03:27:25 -0400 Original-Received: by mail-pg1-f172.google.com with SMTP id c4so5517310pgv.11 for <51446@debbugs.gnu.org>; Thu, 28 Oct 2021 00:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=u37s2vMMxWIBp02OOs/5mu6PZaJBofFGMRD8e+Ot8Xg=; b=gGUZA81EXIeScrG6w34wQ4ZZ8VAuskTe6Tb/x4Xm985Y9tVaArsu7HQ3hBXpRP4Dxy SxP8muEWHJQ7N7uSMIY9+8J6dmxy8aG40QlGml+cK+ADsh8NPNvRlxefWd9Ur29Zvt+V 9wKmz804licB4yzyhEjWRM2yRoMCGIf6aik/a4kGoE4UFDV4iZMs7ELOmxtDpBsH36ZK RNCktNSj7QJ/CpdIUAZWGNwJJdHsRXIp7nOq1CSO+o9/lK1aVSjOdxycTmLa6htZyG22 AH6uvUB5bEuS2ufAbWFG4ts5OqrMUEgLk6mnY9+dvitcXy8Sm2VQ1WuE1UqYOK1baXMk BVUQ== X-Gm-Message-State: AOAM5327tXc7MCWS964Llhrhl+7K4dlCXgSBYhdm85vkf+iPcAeMLVP0 XbDzQSM4nFI7KD7Gt1VhfkxwG8T/1QiU/pAyUfyHRksZ X-Google-Smtp-Source: ABdhPJyN05YC7v5T3/jE3G5u2eWsiGctA4aQ5sMuyTW8wYtxHYbSrb8EkWZ8VSzEbYvOdTvZocbMT9EDmGyNfqDmlb8= X-Received: by 2002:a63:b958:: with SMTP id v24mr1991654pgo.114.1635406038401; Thu, 28 Oct 2021 00:27:18 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Oct 2021 00:27:18 -0700 In-Reply-To: <83v91htz4d.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218489 Archived-At: Eli Zaretskii writes: > I don't understand: I seem to see the same order of the menu items in > Emacs 27 and on the current release branch, so what am I missing? The regression was introduced in Emacs 26.1, in these commits: $ git tag --contain=bed0373855ea | head -3 emacs-26.0.90 emacs-26.0.91 emacs-26.1 $ git tag --contain=b905454680c7 | head -3 emacs-26.0.90 emacs-26.0.91 emacs-26.1 It's the easy-to-make mistake of converting to easy-menu-define without realizing that the order is not reversed there.