From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Wed, 7 Dec 2022 16:19:30 -0800 Message-ID: References: <87v8mndrla.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28896"; mail-complaints-to="usenet@ciao.gmane.io" To: Augusto Stoffel , 59888@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 01:20:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p34eR-0007Oc-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 01:20:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p34dx-0002ed-FP; Wed, 07 Dec 2022 19:20:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p34du-0002dW-SH for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p34du-000365-I8 for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p34du-0004yB-09 for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 19:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167045878119080 (code B ref 59888); Thu, 08 Dec 2022 00:20:01 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 8 Dec 2022 00:19:41 +0000 Original-Received: from localhost ([127.0.0.1]:53043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p34dY-0004xg-RT for submit@debbugs.gnu.org; Wed, 07 Dec 2022 19:19:41 -0500 Original-Received: from mail-oa1-f45.google.com ([209.85.160.45]:42671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p34dU-0004xZ-D9 for 59888@debbugs.gnu.org; Wed, 07 Dec 2022 19:19:39 -0500 Original-Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-142b72a728fso75897fac.9 for <59888@debbugs.gnu.org>; Wed, 07 Dec 2022 16:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=qzi05pBzTOGDByLmEHGMuIOshfhQQMsi9wfjTaeF4rM=; b=V+8xIfZd1uaWG2woPLl7ZJupp04vXkLDgSrK3/Y+ifRYecjt1wkmMqJ5zdQ2USS2b2 PDWXiRRhgd3DMsxPTaWGeOBL8amAQcsPhtCyp/pNA78YOpGLBI13YK/NfMkDy2ay3mgb seddwJulxViV4ThRCK5mXrPNXBvraUmu8UxlxvRWcUJaMklQZDh5JTMfz2H6vxYnBA2c vycBdxVQnlOq216escUCCrp5HSSRcqoRY8rw73WAvW+ZglB0sGeLXI8VsTzfytUUeLqG jOf89u6KmbasDajeTecdRgqmzG6x3TLtlz0FGRd7o/cB7yCyIVhE6R44Smxid27PTlMQ m8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qzi05pBzTOGDByLmEHGMuIOshfhQQMsi9wfjTaeF4rM=; b=vfykYeL+axXEnfUDVavyM+ikTYAl0WDwnBcSyk6Xz8shoMp/wq8wIz4YadqJcfWC3T NtL29oNE4UMkYWl7/K6F9xwIVj1CtlbOilcAJOws3dXZ44emK0VSVVF0fpRRxgyRSZCR vRm9T4kJMvwkesFYQEnXDSD7LNAOiwlDzaJLPH88QMZ+dRZEc7Ng6MLNsm6W8ASee2gL jQBW7zyCHRaW6Ry1a+tU6f/4nuQoUAGUolO3edGrzmdQw+NiM6OogZnLv7IcWKDs9QQ1 WemEE1Luc8DZ8KuJncdzqpPQ8g7yHxw709HSKdm4DOGB3/oXBEXuatj/UM35GPKttC92 PnCQ== X-Gm-Message-State: ANoB5pl6YdT2MOKPHnV0XgljI2il6/C+HhWQ3/BnK5Mom1UvKfRDroEt sxebjtrwNt0puqz+OzhtCQbyC9v4fGKXARuOmvc= X-Google-Smtp-Source: AA0mqf5ZDuLydfbAvGVx2ECzMYL+MhptgZEgI7uFQBuUNEYzDJFm1ujs2YLxVnWcAMJvfnI9QxUBzd/Mp1C1HMSMlHk= X-Received: by 2002:a05:6870:9e9a:b0:144:307b:c8d1 with SMTP id pu26-20020a0568709e9a00b00144307bc8d1mr14597667oab.92.1670458770787; Wed, 07 Dec 2022 16:19:30 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Dec 2022 16:19:30 -0800 In-Reply-To: <87v8mndrla.fsf@gmail.com> X-Hashcash: 1:20:221208:59888@debbugs.gnu.org::V5qCijSMpwzybXsQ:Az++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250227 Archived-At: Augusto Stoffel writes: > From 2247f006845000032fedc3dda9a073b14043a270 Mon Sep 17 00:00:00 2001 > From: Augusto Stoffel > Date: Wed, 7 Dec 2022 18:44:07 +0100 > Subject: [PATCH] Add 'grep-heading-mode' > > New minor mode to subdivide grep output into sections, as in the > '--heading' option of certain grep-like programs. > > * lisp/progmodes/grep.el (grep-heading-regexp): New user option. > (grep-heading): New face. > (grep--heading-format, grep--current-heading, grep--heading-filter): > Filter function for grep processes and supporting variables. > (grep-heading-mode): New minor mode. How about making this into a defcustom instead of a minor mode? I'm thinking that something like (setopt grep-use-headings t) is a slightly simpler interface to use than (add-hook 'grep-mode-hook 'grep-heading-mode) I also think the former plays a bit better with customize.