From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#63511: [Patch] Fix for hidden window bug Date: Thu, 24 Aug 2023 01:24:11 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63511@debbugs.gnu.org To: Christian Schmidt , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 01:25:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYxDu-00038S-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 01:25:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYxDg-0004zM-DK; Wed, 23 Aug 2023 19:25:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYxDe-0004z0-Ii for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:24:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYxDe-0005DJ-AT for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:24:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYxDh-0008Ew-T6 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 19:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63511-submit@debbugs.gnu.org id=B63511.169283307431627 (code B ref 63511); Wed, 23 Aug 2023 23:25:01 +0000 Original-Received: (at 63511) by debbugs.gnu.org; 23 Aug 2023 23:24:34 +0000 Original-Received: from localhost ([127.0.0.1]:35555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxDG-0008E1-1Q for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:24:34 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:57454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxDD-0008Dm-I4 for 63511@debbugs.gnu.org; Wed, 23 Aug 2023 19:24:32 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-52a1ce52ef4so2874805a12.2 for <63511@debbugs.gnu.org>; Wed, 23 Aug 2023 16:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692833062; x=1693437862; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3Wq4re1cn6auQ0vRExVwB8cl8MYOFsStWdhRHxp1SYs=; b=NKMsgJZeRrCgXI+H+reb+t+q0Q4t3RTboJDxoFTtUh3VSHnyIsB7dUaH39oSHQsmED rCNbuF+Azx/1xNgZj0bhfzCDpbH6EhvI8ij74KibQOZUcI1vr3zcU1s/s0Fpa5iZsvIU bjt1WDSu4rRcKAZq2qzGYbvZEYg0CbQA1WRx4hUg3mzyH8glgJ/vyDgJGTjnFSpUEs5i 7vTWemzM8mvFHEf38DIc7HcnmZDc0GYKJhE28CZ7NWV3annwtk110JjqoOMm1R0HC8F+ TWf4Yfn36N7AAmyLl6v8vEC3z0+o1Ulk12teYLw3t+AmPG3X1nr1mlrtVEwZnRgiDU0H 1jOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692833062; x=1693437862; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Wq4re1cn6auQ0vRExVwB8cl8MYOFsStWdhRHxp1SYs=; b=YmIRW0O8tJcDWaDZ5tZRgVyQmdT5VLr1Kc4FlCWhOW2+joLcedKLafII8/9kjvAe2E QAwHbfbyewsYBiC95nLKGmNyYU4CgYrXW1ZUM23gV8k9PRiFg5BAYnhuJPKSj1cQkv34 mFr4ercgIz6Ra2jzWanz4DSh8/XKAMy81jaFtJADZR3WGiyHZJ/sH9FaZyvGLL6iZwSx qyhNM1FneHh2voOq+rppy53OHZQEhnifoPn5XpX/oqjni5G8viBJXbMdl0AHwaUk5CM2 J3/byFKUFHzpLF/EZQmMQ+00CTKvdMJ2Xau2I0W0hV2f7/0ZAmcZY3TUhL7NkYhElyVb BNSA== X-Gm-Message-State: AOJu0YwohjG982MNWUKBc47JlsIHWNvKePrUtHzieLyW7UfSPo/FMvJp TLKwz276amSAQ5EiQG7j96ZWcp3vIyI88CJeP1IGdoYy1WA= X-Google-Smtp-Source: AGHT+IEPGKmrIUbbnBlgVTey84wuWUGhu5bDTryvga8jr1VQRcRvIRQBoF3QWy+mSfNMbqjIL0TddgHBxOxNY+HwRKE= X-Received: by 2002:a05:6402:b1b:b0:525:6d6e:ed4a with SMTP id bm27-20020a0564020b1b00b005256d6eed4amr11080365edb.23.1692833062019; Wed, 23 Aug 2023 16:24:22 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268280 Archived-At: Christian Schmidt writes: > At least on enlightenment, when switching virtual desktop away from the > on containing emacs and back, emacs does not render screen updates. > This patch fixes the cause. > Analysis for the bug tracker, copied from commit message: > > If no state flags are set in the _NET_WM_STATE property, > the returned X property type will be "0". This situation > occurs when "_NET_WM_STATE_HIDDEN" was the only property > set for the emacs window, e.g. in enlightenment due to > change of a virtual desktop. > In the current code this causes copying of the iconified > state in x_get_current_wm_state(), which causes emacs to > stay hidden. For DMs such as Enlightenent or Gnome Shell > that use only the hidden but not the iconified state > this clashes with the intention of handling the > _NET_WM_STATE property notification in > handle_one_xevent(), which requires not_hidden && > FRAME_ICONIFIED_P (f) to actually activate the frame. Po, could you take a look at this patch please.