all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master 97679d06e8 1/2: Avoid an unnecessary call to intern
Date: Mon, 19 Sep 2022 09:23:35 -0400	[thread overview]
Message-ID: <CADwFkmk6prBYNr6ZWZXXmZcZ_y=v4NMGkAzeDHbgdwTBBq=5Ag@mail.gmail.com> (raw)
In-Reply-To: <87pmfroe96.fsf@yahoo.com>

Po Lu <luangruo@yahoo.com> writes:

>>     * src/doc.c (Fdocumentation): Prefer DEFSYM to using intern directly.
>
> Maybe we should get rid of all of the calls to intern with a static
> string in one go?

Sounds good to me.

> I think leaving them there is really just a waste of cycles.

Getting rid of them also gives us compile-time error checking, which is
nice.



      reply	other threads:[~2022-09-19 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166358035244.5217.7919161622861356432@vcs2.savannah.gnu.org>
     [not found] ` <20220919093912.CB62CC0270B@vcs2.savannah.gnu.org>
2022-09-19 10:22   ` master 97679d06e8 1/2: Avoid an unnecessary call to intern Po Lu
2022-09-19 13:23     ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmk6prBYNr6ZWZXXmZcZ_y=v4NMGkAzeDHbgdwTBBq=5Ag@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.