From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44733: Nested let bindings for non-local DEFVAR_PER_BUFFER variables unwind wrong Date: Sat, 23 Oct 2021 03:19:42 -0700 Message-ID: References: <877dqikpmj.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20116"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Spencer Baugh , 44733@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 23 12:20:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1meE8u-00053N-2k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 12:20:48 +0200 Original-Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meE8s-0006Ne-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 06:20:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meE8A-0006NK-Vf for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 06:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meE8A-0004mD-N9 for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 06:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1meE8A-0004iu-IC for bug-gnu-emacs@gnu.org; Sat, 23 Oct 2021 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Oct 2021 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44733 X-GNU-PR-Package: emacs Original-Received: via spool by 44733-submit@debbugs.gnu.org id=B44733.163498439118127 (code B ref 44733); Sat, 23 Oct 2021 10:20:02 +0000 Original-Received: (at 44733) by debbugs.gnu.org; 23 Oct 2021 10:19:51 +0000 Original-Received: from localhost ([127.0.0.1]:34444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meE7y-0004iF-LK for submit@debbugs.gnu.org; Sat, 23 Oct 2021 06:19:50 -0400 Original-Received: from mail-pf1-f174.google.com ([209.85.210.174]:33639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meE7w-0004hz-Gh for 44733@debbugs.gnu.org; Sat, 23 Oct 2021 06:19:48 -0400 Original-Received: by mail-pf1-f174.google.com with SMTP id t184so5944349pfd.0 for <44733@debbugs.gnu.org>; Sat, 23 Oct 2021 03:19:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=36CbIRY1Xn8SF1JplOkYIKIlSyHXXfPCftorCPWUOgc=; b=NGWK50ka169hz6VMISpYUUZHeEgiswdKXPuUdZ3WJOUnmlibEMF1yFx+Z89XJf1C+9 3HwLksDVBlhA7H8B0i2q8MoZlqHaPu3onQEvWde2dAj5fMtwW6fb59YP7asRJjCBolr8 D0/LwWokx8uivb63z2ra8ikrex6c28bS5uzS4MQzt2oBrYZIYYy36XKp3mffLqfqnYCF sNbTWnHXoEzSh7e/ssTcq0WtBYSY3Uv1QNLpHtTib5lIpLyVtNtuHcpI+56uTwy/JF3X Hl7sgsNy09yUkqUo2nRUL7NWZb+mrfSCt1w4Wugo/v0mpQmm+irVoHPoWrY50A2iAj3C Wb+w== X-Gm-Message-State: AOAM532q1iO6mUbwCiiGa3qyxfRdjGjdL34fHcMimVUps+KNFFYqNqZt UNPUeQKqW69sBPLUWKXX2x246/yCbL/017eJF09skrMuZTk= X-Google-Smtp-Source: ABdhPJw7WmDkA4NzzkMzsU2GEmfsbsEJCi206ZjB93y59RtkWzwrCrddqq04kWIGp+v3EXG0MpWJhR6uoh19YY64+7Q= X-Received: by 2002:a63:81c2:: with SMTP id t185mr4091852pgd.114.1634984382701; Sat, 23 Oct 2021 03:19:42 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 23 Oct 2021 03:19:42 -0700 In-Reply-To: (Stefan Monnier's message of "Thu, 19 Nov 2020 17:14:01 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217968 Archived-At: close 44733 28.1 thanks Stefan Monnier writes: > I just pushed a fix for that, along with the corresponding test case, It seems like this was fixed but never closed, so I'm closing it now. commit 8fac2444641567b10f4c38b599636aeae0478e68 Author: Stefan Monnier Date: Thu Nov 19 17:13:04 2020 -0500 * src/data.c (set_internal): Fix bug#44733 Set the default value when `set` encounters a PER_BUFFER variable which has been let-bound globally, to match the behavior seen with `make-variable-buffer-local`. * test/src/data-tests.el (binding-test--let-buffer-local): Add corresponding test. (data-tests--set-default-per-buffer): Add tentative test for the performance problem encountered in bug#41029.