From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display box cursor under image with margins Date: Sun, 10 May 2020 05:52:32 -0700 Message-ID: References: <83imhwk7sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="24964"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel To: Evgeny Zajcev , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 10 14:53:25 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXlSP-0006Nm-9O for ged-emacs-devel@m.gmane-mx.org; Sun, 10 May 2020 14:53:25 +0200 Original-Received: from localhost ([::1]:41536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXlSO-00042s-8k for ged-emacs-devel@m.gmane-mx.org; Sun, 10 May 2020 08:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXlRb-0003cO-Dl for emacs-devel@gnu.org; Sun, 10 May 2020 08:52:35 -0400 Original-Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:40442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXlRa-0006ig-Fy; Sun, 10 May 2020 08:52:35 -0400 Original-Received: by mail-yb1-xb44.google.com with SMTP id c2so3631926ybi.7; Sun, 10 May 2020 05:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=o69A/FaxtSAtuLqaDrE7VS8yXwoN+73EYB2HUIjkuWE=; b=B7iIFaYHztku6TSxRU/oXOFHhc/1AdQo5gKKAA/d7cdVREia/hScOjeXkYizBx5f/N kw9wrf9VxYRPiOgfHq1GKhzL/IDhBlV19COB+9M+LyeOf5SUzfgCqNKOqC10mMrWpjdL 5bTvPCA11u80nG5VceXs5uYytIZA4MVhbMgj+USVMAgx3PsTCkE0t2JEW0wTa/EzNxDe l/LKTPOLkI7Hrofxor0UVw7TPbDvgHpL2tdVseC4Ifa4emqpsVrKsj0Vh9Ko2naC1Gyx uHXUZ/4sKOsDxRZFWDQNBReDxJYi2eabVDhbCxz4L+FTE/vkjrHfYPdjX7hM6ybcnto/ wuRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=o69A/FaxtSAtuLqaDrE7VS8yXwoN+73EYB2HUIjkuWE=; b=qi2wtTQ91XNH9bmmoqoYNi2MP9wrbhKzvQBETHOLiF8BxjfVFm7SEgG743BHfbdiG0 +vfqffNoVsASW4UChqrJNVWURSXAAAxsR8mqOLfMHFm5pr8ariLLElujKupPLClMdWxr mOZvzYD7dKCzbfcvc2KAtYIWHSVWNsnSZPTQWNWH8po8FIDuLKGEQH/Gu4bb6mUcAi62 sJ91oAmp53TztEMsvXz4c6f+jsxBy0sob/z/Lpex2bIcH5YCJIaAvJG5pEjBB2lIP8Jw 8hWi5QWn3oqhby8BYEpysi3YfWjSnp3MtvBR7RVSZea9MPsv445I8RL9IRqkR9usmhLb EPsQ== X-Gm-Message-State: AGi0PuYvgVd9+cYVqbolFls3SaTC4OxTQZ24yA5oGRSYf8xbO8its1KJ Ele14ayIaA7KeFsyD7AupojQYLbn4Xx0GkFD+ik= X-Google-Smtp-Source: APiQypIbQWpRHGu88TAx27at5d7/O6n8FrBQbp+6k8f6KCbFaGkdCyesZmOFTjvpvxK0uvEzKsCnMW5nW0e0BxF6b1c= X-Received: by 2002:a25:af86:: with SMTP id g6mr17945665ybh.85.1589115152974; Sun, 10 May 2020 05:52:32 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 May 2020 05:52:32 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b44; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249651 Archived-At: Evgeny Zajcev writes: > =D1=81=D0=B1, 25 =D0=B0=D0=BF=D1=80. 2020 =D0=B3. =D0=B2 15:09, Stefan Mo= nnier : > >> > Here is first screenshot how hollow cursor looks on image with margin = - >> > http://lgarc.narod.ru/pics/emacs-hollow-cursor.png >> > >> > And here is how it looks with patch applied - >> > http://lgarc.narod.ru/pics/emacs-box-cursor.png >> >> Would it be possible to keep the two thin horizontal lines when the >> window is active? >> > I figured out, how to do this in "easy" way. Here is patches update > > And screenshots: http://lgarc.narod.ru/pics/emacs-box-margin1.png > http://lgarc.narod.ru/pics/emacs-box-margin2.png I think your second set of screenshots looks better. But the horizontal lines are not thin, right? What happens when you switch the active window? Will the cursor change the size of that line, causing things to move vertically? And what's the result when you have many images in a buffer, as in image-dired? Best regards, Stefan Kangas