all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change
       [not found] ` <20211202035202.04FD820ABB@vcs0.savannah.gnu.org>
@ 2021-12-02 12:31   ` Lars Ingebrigtsen
  2021-12-02 12:48     ` Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-02 12:31 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

monnier--- via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
>     * lisp/emacs-lisp/macroexp.el: Improve last change
>
>     Don't burp when `byte-compile-warning-enabled-p` is not yet defined.
>     And use the call that we had already instead of adding a new one.

This (or something else recently) seems to lead to a failure in

Test comp-tests-45603-1 backtrace:

with nativecomp.  I'm guessing it has something to do with this commit
because it mumbles something about

#<subr byte-compile-warning-enabled-p>

but it's a bit hard to understand what the real error is.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change
  2021-12-02 12:31   ` master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change Lars Ingebrigtsen
@ 2021-12-02 12:48     ` Stefan Kangas
  2021-12-02 15:49       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-12-02 12:48 UTC (permalink / raw)
  To: Lars Ingebrigtsen, emacs-devel; +Cc: Stefan Monnier

Lars Ingebrigtsen <larsi@gnus.org> writes:

> monnier--- via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>>     * lisp/emacs-lisp/macroexp.el: Improve last change
>>
>>     Don't burp when `byte-compile-warning-enabled-p` is not yet defined.
>>     And use the call that we had already instead of adding a new one.
>
> This (or something else recently) seems to lead to a failure in

I've just finished bisecting these recently introduced errors and this
commit is indeed the culprit.

> Test comp-tests-45603-1 backtrace:
>
> with nativecomp.  I'm guessing it has something to do with this commit
> because it mumbles something about
>
> #<subr byte-compile-warning-enabled-p>
>
> but it's a bit hard to understand what the real error is.

I'm seeing this as well:

4 files did not contain any tests:
  lisp/net/ntlm-tests.log
  lisp/emacs-lisp/eieio-tests/eieio-tests.log
  lisp/emacs-lisp/eieio-tests/eieio-test-persist.log
  lisp/cedet/srecode/fields-tests.log

With errors like:

In toplevel form:
lisp/emacs-lisp/eieio-tests/eieio-tests.el:36:1: Error: Wrong number
of arguments: #<subr byte-compile-warning-enabled-p>, 0
make[3]: *** [Makefile:165: lisp/emacs-lisp/eieio-tests/eieio-tests.elc] Error 1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change
  2021-12-02 12:48     ` Stefan Kangas
@ 2021-12-02 15:49       ` Lars Ingebrigtsen
  2021-12-02 19:58         ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-02 15:49 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Stefan Monnier, emacs-devel

Stefan Kangas <stefankangas@gmail.com> writes:

>>>     Don't burp when `byte-compile-warning-enabled-p` is not yet defined.
>>>     And use the call that we had already instead of adding a new one.
>>
>> This (or something else recently) seems to lead to a failure in
>
> I've just finished bisecting these recently introduced errors and this
> commit is indeed the culprit.

I've now changed it to not bug out, but I haven't looked closely at the
logic -- why is the `warning' a nil there anyway?

> I'm seeing this as well:
>
> 4 files did not contain any tests:
>   lisp/net/ntlm-tests.log
>   lisp/emacs-lisp/eieio-tests/eieio-tests.log
>   lisp/emacs-lisp/eieio-tests/eieio-test-persist.log
>   lisp/cedet/srecode/fields-tests.log
>
> With errors like:
>
> In toplevel form:
> lisp/emacs-lisp/eieio-tests/eieio-tests.el:36:1: Error: Wrong number
> of arguments: #<subr byte-compile-warning-enabled-p>, 0
> make[3]: *** [Makefile:165: lisp/emacs-lisp/eieio-tests/eieio-tests.elc] Error 1

These also seem to work now...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change
  2021-12-02 15:49       ` Lars Ingebrigtsen
@ 2021-12-02 19:58         ` Stefan Monnier
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2021-12-02 19:58 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Stefan Kangas, emacs-devel

> I've now changed it to not bug out, but I haven't looked closely at the
> logic

You made exactly the same change I was about to commit (down to the
change in layout to fix the excessive indentation).

> -- why is the `warning' a nil there anyway?

It's not the warning but the "category" where nil means it's not in any
particular category.


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-02 19:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20211202035200.9877.9609@vcs0.savannah.gnu.org>
     [not found] ` <20211202035202.04FD820ABB@vcs0.savannah.gnu.org>
2021-12-02 12:31   ` master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change Lars Ingebrigtsen
2021-12-02 12:48     ` Stefan Kangas
2021-12-02 15:49       ` Lars Ingebrigtsen
2021-12-02 19:58         ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.