From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command' Date: Sat, 6 Jul 2024 10:15:13 -0700 Message-ID: References: <172023408734.9826.6615246233994903888@vcs2.savannah.gnu.org> <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13773"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jim Porter , Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 19:16:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ914-0003KR-2Y for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 19:16:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ90K-0006sm-1V; Sat, 06 Jul 2024 13:15:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ90I-0006qA-9G for emacs-devel@gnu.org; Sat, 06 Jul 2024 13:15:18 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQ90G-0008AZ-Kz for emacs-devel@gnu.org; Sat, 06 Jul 2024 13:15:17 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-58c2e5e8649so5401548a12.1 for ; Sat, 06 Jul 2024 10:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720286114; x=1720890914; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=me8XdqrocNo7zl9knQDMFZGuhgYLOKI0twPxoG0xvsM=; b=SLLfc5U2TtD4w2LAl/qELJOhzCvdNpkOyC7FcTV+L8nNshhHVHV26LcEjSGLQxuDXT 3UeoNW6GR0hs9PQlt+OYc5BBY5RDXa2qj4wJyTr+wUySQD4QMb6KdCpc/Y4qnbJH2DQg 9CSPgueoYL66hsDLyZNaoUigXoZgu332jHDN5DagwGQOcdq5x2T/mUnbQt8stq6a3cOA 9K9rk+U3uE3GsXGbAmz0drJXCaK07/H/vccFu7tUD70nGtp1Wu76UblQT+u34jjuZRlT zTkyGFcLMb5qrIPC7hWeuk8129Q7hLOhLvl7AbMF2SxccPUSMwi5GvVT5Sy79Q5yKpXT Ed8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720286114; x=1720890914; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=me8XdqrocNo7zl9knQDMFZGuhgYLOKI0twPxoG0xvsM=; b=JbsV0M2VQhFpH6tlHyb7EFt8rNhPJl7uUsc7bnghARPw71+YmcB3Zee1kjB84nuE/j LvOskKIFZIsXiCs2k+2iU9LOdxUB29EBTzMmm2OZwnqkh8EIdQjn1nNA5Jr8euA6tM87 63rZQJzPsaNhmJ8n8+Up9z9A7sKLiImB1uogpROSDQdTS66fH16L97tpO4tRmDR/C6to tB4dWARepYTdlpUFuWVwzXBRyJZ+NgtbTIBtV/PtZlDODliNt4cXw9QbbylSajwExR84 zH4j5vUlaiZ4MVG5oNeY1pnQBrlGb/16REF1iglym+qAn4guwzar1fsA5H5eVscWKoR2 Bd8g== X-Gm-Message-State: AOJu0YwlSMy3y4B20P0sJeEnZ4PrDA3uk8KARBr/lyi9hf9ax9EZE/V+ K+Abp2Gusdm2rLlYShGsgZbztQNX1IltrrsgsajDCPmAPd/wglPvwD0Gu/qnjzRho3la+EuRFOh MzNVskKPQ8TLEWDMuw3TOLZDmvpY= X-Google-Smtp-Source: AGHT+IHdfN5OKEAyVIMnack3AOuAKnF4KyiYC9OAAWBLP35jEGWODagpz815s1SQzE5COkKI9bjAutnVQIus+kLqi3k= X-Received: by 2002:a05:6402:5110:b0:57c:c171:2fb6 with SMTP id 4fb4d7f45d1cf-58e7a74d33dmr5441647a12.1.1720286114171; Sat, 06 Jul 2024 10:15:14 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 6 Jul 2024 10:15:13 -0700 In-Reply-To: <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321448 Archived-At: Jim Porter writes: > branch: master > commit 7f631a3e2aca97e95b8659c902c25ab21f084e08 > Author: Thierry Volpiatto > Commit: Jim Porter > > Allow using multiple buffers in 'eshell-command' > > Provide the same functionality as 'async-shell-command-buffer' but fo= r > 'eshell-command'. > > Co-Authored-By: Jim Porter > > * lisp/eshell/eshell.el (eshell-command-async-buffer): New option... > (eshell-command): ... use it. > > * lisp/eshell/esh-proc.el (eshell-sentinel): Check for buffer livenes= s > in 'finish-io'. > > * test/lisp/eshell/eshell-tests.el > (eshell-test/eshell-command/output-buffer/async-kill): New test. This new test is failing here: Test eshell-test/eshell-command/output-buffer/async-kill backtrace: rename-buffer("*Eshell Async Command Output*" nil) eshell-command("*echo bye &") #f(compiled-function () #)() #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eshell-test/eshell-command/output-buf ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [... ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l command-line() normal-top-level() Test eshell-test/eshell-command/output-buffer/async-kill condition: (error "Buffer name =E2=80=98*Eshell Async Command Output*=E2=80=99 is = in use") FAILED 5/16 eshell-test/eshell-command/output-buffer/async-kill (0.005699 sec) at lisp/eshell/eshell-tests.el:120