Re: master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command'

[Stefan Kangas <stefankangas@gmail.com>]

Jim Porter <jporterbugs@gmail.com> writes:

> branch: master
> commit 7f631a3e2aca97e95b8659c902c25ab21f084e08
> Author: Thierry Volpiatto <thievol@posteo.net>
> Commit: Jim Porter <jporterbugs@gmail.com>
>
>     Allow using multiple buffers in 'eshell-command'
>
>     Provide the same functionality as 'async-shell-command-buffer' but for
>     'eshell-command'.
>
>     Co-Authored-By: Jim Porter <jporterbugs@gmail.com>
>
>     * lisp/eshell/eshell.el (eshell-command-async-buffer): New option...
>     (eshell-command): ... use it.
>
>     * lisp/eshell/esh-proc.el (eshell-sentinel): Check for buffer liveness
>     in 'finish-io'.
>
>     * test/lisp/eshell/eshell-tests.el
>     (eshell-test/eshell-command/output-buffer/async-kill): New test.

This new test is failing here:

Test eshell-test/eshell-command/output-buffer/async-kill backtrace:
  rename-buffer("*Eshell Async Command Output*" nil)
  eshell-command("*echo bye &")
  #f(compiled-function () #<bytecode -0x9447a45fbdbd42>)()
  #f(compiled-function () #<bytecode 0x4e527f523db3b2e>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x4e527f523db3b2e>
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name eshell-test/eshell-command/output-buf
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test eshell-test/eshell-command/output-buffer/async-kill condition:
    (error "Buffer name ‘*Eshell Async Command Output*’ is in use")
   FAILED   5/16  eshell-test/eshell-command/output-buffer/async-kill
(0.005699 sec) at lisp/eshell/eshell-tests.el:120