From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68028: 29.1; (elisp) `pcase Macro': move `rx' before SEQPAT description Date: Thu, 28 Dec 2023 07:43:22 -0800 Message-ID: References: <1529B1FB-6C99-4D3C-8B36-F9951CC49FF7@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Drew Adams , 68028@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 28 16:44:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIsYa-0009Z7-DH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Dec 2023 16:44:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIsYG-0003sn-Sc; Thu, 28 Dec 2023 10:44:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIsYE-0003sV-IC for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 10:44:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIsYE-0000wz-AS for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 10:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rIsYD-0002h3-JJ for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 10:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Dec 2023 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68028 X-GNU-PR-Package: emacs Original-Received: via spool by 68028-submit@debbugs.gnu.org id=B68028.170377821010308 (code B ref 68028); Thu, 28 Dec 2023 15:44:01 +0000 Original-Received: (at 68028) by debbugs.gnu.org; 28 Dec 2023 15:43:30 +0000 Original-Received: from localhost ([127.0.0.1]:40191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIsXi-0002gB-F1 for submit@debbugs.gnu.org; Thu, 28 Dec 2023 10:43:30 -0500 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:51703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIsXg-0002fy-Fs for 68028@debbugs.gnu.org; Thu, 28 Dec 2023 10:43:29 -0500 Original-Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-54cb4fa667bso7435852a12.3 for <68028@debbugs.gnu.org>; Thu, 28 Dec 2023 07:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703778203; x=1704383003; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=+ooAcISE3C901rCCEup53zLBzt4b77fh7BaoFmDbo1Q=; b=am9U/ZJJcSwoJvnLBFd0Sb4nmKq2lfEBE54m6OvAomkxpPudkTfFu4YRte2lN0QxB9 ajYMfmgWkAgMfuBOwkq/6DyFiqUTGvYRTFe29kevWikFzebTH6sexBCp7kH2AfoYWzCX 4vwdO3fwLM5HtZkLCsWGIM3k4fRrJSHg+gMXAJ9JogDZie33NpF2vjWH4fkxa8kmD9G9 dH9d2acswKk+YyedpdGuOvD4TZ0wf7VDL0Z9xVRAuhD4jmNOE9BqkdZwtdiSlVl4zGg4 dCwKkTAy2glP6zhLOt8bSNRmNcUZiCn2gqHvC8n12bAy7unX4FTlID4SiMOqg/J6/7aV Sbqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703778203; x=1704383003; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+ooAcISE3C901rCCEup53zLBzt4b77fh7BaoFmDbo1Q=; b=JAqfy9Me6frbgCDKC3laaisG942/D3Xxcz44eVenCuV/AOBcVY9eDvKf7Pnk85bNGk SVMRf33DSZzZHI5oheOT8a+RRbCtOPkWFmSmFGvndNtSZJZYAJ6durtlkKeSnjZeuTNc HBxbmNzDzzBbn1ZUQGGcCCdoMSWs8cP3PIr3d0bTlNfwwYXpE+lcmqfk4AB1OfZtWydD kDgXJRzOUIIsZqwWKID9HWExKTM1cEzcS7lzUJrjgvSlkVCvIphdkKBj4x31+Eds9YxX u/42SHgt3Eyj+EbuTL+blS3Mnh4yPcT60BuSivpXE//pciH+KmXeEnzgHxCNhnGeocmP wB1Q== X-Gm-Message-State: AOJu0YyniEJanaYgwg+XsifWNnxu7Z7RLIUpyNMyrkVPYn9AMYJC8q1T ZJTW6zvQ7xDJ1BsN0jf7Lh/4KOp+SidAVnfu+DE= X-Google-Smtp-Source: AGHT+IHHN5uIMj7vUMohrwAdPZOmbuPGJCgDE5NRnGushs2xBzgbuEZXCwr8amSHPbakC3bzQZlKIHngyIft6t3Q3o0= X-Received: by 2002:a50:d598:0:b0:553:6de7:3157 with SMTP id v24-20020a50d598000000b005536de73157mr5973396edi.76.1703778202679; Thu, 28 Dec 2023 07:43:22 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Dec 2023 07:43:22 -0800 In-Reply-To: <1529B1FB-6C99-4D3C-8B36-F9951CC49FF7@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276983 Archived-At: Mattias Engdeg=C3=A5rd writes: > I suggest we remove that paragraph because it doesn't actually say > anything useful at that point; the user can learn how `or` and `and` > patterns work without knowing that they are SEQPATs. Actually, I'd > hoist those two patterns and reorder them to keep patterns in a rough > order of usage: something like > > pred, guard, or, and, let, app, rx > > makes more sense -- `pred` and `guard` clearly belong together, `app` > is less common than `let`. > > We could explain SEQPAT in a short sentence somewhere else, either > near the beginning of the node or further down in the 'Caveats' > subsection. A simple (and probably flawed) patch attached. > > Stefan M probably has a better sense of how to improve the text. (By > the way, the caveat section says that sequencing patterns use `eq` for > comparison. Don't they use `eql`?) Makes sense to me. Perhaps your patch could be installed first, and then we can take it from there.