From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sat, 13 Jan 2024 02:02:53 -0600 Message-ID: References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37587"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 13 09:03:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOYzX-0009W0-Th for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jan 2024 09:03:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOYyo-0008G9-RY; Sat, 13 Jan 2024 03:02:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOYyn-0008Fj-GX for emacs-devel@gnu.org; Sat, 13 Jan 2024 03:02:57 -0500 Original-Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOYyl-0002FR-VH; Sat, 13 Jan 2024 03:02:57 -0500 Original-Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-557bfc7f7b4so10328156a12.0; Sat, 13 Jan 2024 00:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705132974; x=1705737774; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=zTP8e1HrUC6+lqFRqPSt+5hB/MIDQ926gf0cfZq51ZI=; b=iJZeA/0YAj89OPGlJy29ELlz2SeJqLyqgbH2f48S6MtF4DNAhMJBLz8Svjk9q7REYh kSU4lTQSUX9mXvboHFt+aMUpGoNaQ9Wu8hwI2F3/SVLSe9RRNHJ402Ou/COlnAiJG0c2 Sae5hT2jI9ZVTLyQFXTEzNklL2fE5nH0MWS4HVneBw2Sahc37vJsTAvklWCOsMIO7Z7z QD1Z0/N9yyutJ5LhyLiul+X1Ziiq/Tnjd1Z6cHFarybWD67oFgjf4UcRFTQBZAyeU+Pb W7/h/MyoJVfFptnJP9cDkoUCzqTuua3OXYCWf881oMpyLgLz8OuOSDQJLsgZLSw3anib 2ZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705132974; x=1705737774; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zTP8e1HrUC6+lqFRqPSt+5hB/MIDQ926gf0cfZq51ZI=; b=gUfo69uaVcxMTs63UpOKnzu9erkYXWN4o653kIBGx28UZ4ESXQDm0bXsvCCiUxCS8T oGgqvO5YgvK2uhzE/GKmmqCwjyAg+Rl4P1CYzRw2WRcTrA0leLhG7jt62iJF4NpD7Mvl YZd8pl6pU+GwQYUl5ESfbhEV1PI9aeGHEZEfCUk8ughFF6t57/yqnj07OYVoafIkfBkg khRLGQCJU0+GPCF+QuADd9z4KTUBkRbfA/8oLYIBvqvmsr/X2kS/HJ8tcEwEVXC2X6NG 90OmbaTTTJgoHti2Ezn9kXF5YmpsBB7sHaFVJsP1W7papikjsiF6Y8KzJbtfWEtAU14Q gHTw== X-Gm-Message-State: AOJu0YyL3Qwbxa4iklr0Vp7fMsFu9HadjUYDIezHjGE4+R9r+kRD51f+ 2qGnjny9PENUpaWJ1ZnnRLsy0/0V7ETotNeeTA4Aynfi X-Google-Smtp-Source: AGHT+IFtRxKian0OTxIJRlsmumYub00ri/nsOHtbAiQB/OAMRjSd85P47436TmBb55MymqwZeaW3p+6lKO8Q2oW4l6I= X-Received: by 2002:a05:6402:1747:b0:558:308f:db04 with SMTP id v7-20020a056402174700b00558308fdb04mr2525209edx.18.1705132973968; Sat, 13 Jan 2024 00:02:53 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 13 Jan 2024 02:02:53 -0600 In-Reply-To: <83o7dyua0d.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314923 Archived-At: Eli Zaretskii writes: > Regardless of portability issues, I think the macro should be called > SWAP, upper-case, to avoid clashes with functions. Upper case more conventional for a macro, indeed. I consider these three as exceptions: min, max, swap. The former two, we already have. But I won't insist on using lower case also for `swap`, if you think it's better not to. Do you think it's worth changing upper case function names to lower case also? I find lower case names makes code more readable.