From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Wed, 14 Dec 2022 13:42:31 -0800 Message-ID: References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> <874ju07vzl.fsf@gmx.de> <87lenbrufm.fsf@gmx.de> <874jtycnp2.fsf@gmx.de> <87r0x2axdy.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27161"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 22:43:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ZX3-0006wt-21 for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 22:43:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5ZWQ-00081R-Iq; Wed, 14 Dec 2022 16:42:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5ZWN-00080s-UP for emacs-devel@gnu.org; Wed, 14 Dec 2022 16:42:36 -0500 Original-Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5ZWL-0004d9-2T for emacs-devel@gnu.org; Wed, 14 Dec 2022 16:42:34 -0500 Original-Received: by mail-ot1-x32b.google.com with SMTP id m6-20020a9d7e86000000b0066ec505ae93so2540994otp.9 for ; Wed, 14 Dec 2022 13:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTm7byNJWI0ja33ncLjKe+T+ji+xBrKiN57vuaj+rLA=; b=Aggi96WlIu5xwU/PHOo/HchAzAXyes0mv8GdckF/BOxhnXaffphdLKqtGy+shAmxCQ 3cEcGaR+HYQKw3T1qsLwPBgDqq4xuoeDurx+gbEv9Tl0TXWpS0nMqlOYbB4cXfqj8tji OudjhQpNco5oF50ve0nhEs+Bik2YVXGvIriTchorXUO9l1j8nsOCCx7dVIOSxFboHvaq Q+DSW879ee1IVbDkvV/4KJkUp1Ylvx4dMTWTwHN3bxmfrJPOttBaGrmfgkQKJyQcQeT5 /rURhpjFhKoC8DXYMLdiD8YaFYOQiA8BYkEAzQ86Hg9X5dPVchGoVaDZ54KZkP2swkcb iFQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kTm7byNJWI0ja33ncLjKe+T+ji+xBrKiN57vuaj+rLA=; b=yW3RAnN9NVLCzRq/3lwhP++giSZViSrBGavekGAmmuRCjzPKpNOl8MY6XssohNalpP 8oa7bFeGqKm78fe0L7boW/Fd1HXxLEZPqbzpJiEJTbIJUjDfOQOyv17d5AoA+XS3ioNG XAuVUo57oALPe3i1/5zQRkjbhLZMyxdg0bXiMJtrTc+iubXaMWSBFo02dHmjKmH/nswL h3PmCCE5jVpaBoJ9jd/44ek2Z0bLM3l8oZjxSIrCXhG8dfURn04GIWUYaK2Y15bOpLzZ MhLefvbkQrbLa9TUIvas/kguk+jAcZG6i0YPusQKH9bC3TofPn7HPs/N7374S4D3iD8H rszQ== X-Gm-Message-State: ANoB5pln1sY7XPJ1GWkz4TFNCC3PBjsCJlma5+UbYO1RWUJrkvolmZld beW5d6bLCj0Z3wJOA5LsL6xxnW3Ys+ho8Ftmawg= X-Google-Smtp-Source: AA0mqf4wUAjHumv2kEoedsrmzVg6cH6Btt4yif9DezcZFliMaoudSSe5KGVk83w05Rsu2i89VYvLedAO13xfstrfGEc= X-Received: by 2002:a9d:6203:0:b0:66e:f6cb:cb4e with SMTP id g3-20020a9d6203000000b0066ef6cbcb4emr8910148otj.105.1671054151701; Wed, 14 Dec 2022 13:42:31 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 14 Dec 2022 13:42:31 -0800 In-Reply-To: X-Hashcash: 1:20:221214:emacs-devel@gnu.org::MKcNE/uCRgO5l3FJ:AHmN Received-SPF: pass client-ip=2607:f8b0:4864:20::32b; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301419 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Wed, Dec 14, 2022 at 2:11 PM Michael Albinus > wrote: > >> Both conventions are used: -test-FOO and -tests-FOO. >> In the test/ subdirectory, (dired-do-find-regexp "deftest.*-tests-") >> returns 1073 lines, and (dired-do-find-regexp "deftest.*-test-") returns >> 1245 lines. If you prefer the "eglot-tests" prefix, rename it (I really >> don't care :-) > > OK. I don't know either, I'll decide later. More conventions are in use than that, and I couldn't confidently say which is the preferred one. Probably it's not that important, as long as every file consistently uses one or the other. FWIW, I don't see any major benefit to having "-test" in the test name, as the fact that it's a test is immediately obvious in all contexts where you see them. So it mostly just makes the test names longer.