From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51032: 29.0.50; Choices for blink-matching-paren Date: Wed, 6 Oct 2021 14:10:45 -0400 Message-ID: References: <86o8831x7o.fsf@gnu.org> <83mtnm2w8o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2946"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, 51032@debbugs.gnu.org, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 06 20:11:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYBNo-0000b1-32 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 20:11:12 +0200 Original-Received: from localhost ([::1]:56084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYBNl-0000V3-Mq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 14:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYBNe-0000Rc-4F for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 14:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYBNd-0002eA-T4 for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 14:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYBNd-0001C0-Le for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 14:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2021 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51032 X-GNU-PR-Package: emacs Original-Received: via spool by 51032-submit@debbugs.gnu.org id=B51032.16335438544569 (code B ref 51032); Wed, 06 Oct 2021 18:11:01 +0000 Original-Received: (at 51032) by debbugs.gnu.org; 6 Oct 2021 18:10:54 +0000 Original-Received: from localhost ([127.0.0.1]:45428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYBNW-0001Bd-Bg for submit@debbugs.gnu.org; Wed, 06 Oct 2021 14:10:54 -0400 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:45704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYBNT-0001BO-BA for 51032@debbugs.gnu.org; Wed, 06 Oct 2021 14:10:52 -0400 Original-Received: by mail-pj1-f44.google.com with SMTP id ls14-20020a17090b350e00b001a00e2251c8so3020695pjb.4 for <51032@debbugs.gnu.org>; Wed, 06 Oct 2021 11:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=QfGuGOzZCdl2ZzmwwS4aLlliUZYnIx5tk7OZdf2yV10=; b=uMSE7elyjfwEpcgbg7J+puiCa+yYJL7iaX2ICCXrEP2hvPWfYb993hDU/sYsSuJbTs j8r+Nujo1+q8kIGjf3+8+mMHwHZck8NETa8PL1IaSz8OMerg4mXhKt//06sirOJWUIz1 I1uj7A8hnnSvgfgTPIha6iGH1pp2fBpg+6WCItGZC3yP3AcAaPgNzyqgMpfyXwTCIVFV 8Qw2xCE9gek/SoQXY/qEP6T7Q4q2F5BtFJyHBv7ZQtVjOMz3FOAePWNWbFbWOlPi0DfG Vzli5LoLa5TmQ/uv0SdydWjEq/0MvVLyg/xKm+hqSFEW7DaKpLLk1wioOKA0QDn+lIT1 5Dyw== X-Gm-Message-State: AOAM5329AdjQEns0DMsetsmVCN07miqZEsoAaP89iDa1xjXC7jB+6rBz N6bQySGg+h30Jomvn4Z0HJMHUxMzdO3luaCTEgE= X-Google-Smtp-Source: ABdhPJzsD538cfbROkAQ+uZBATmIZMKelGAZtVqwvysCxdrQN7oA3uo0vyuItbGnbQDyVm8KXiSFK2hOlYbyuRXvX0E= X-Received: by 2002:a17:90a:460a:: with SMTP id w10mr195300pjg.132.1633543845696; Wed, 06 Oct 2021 11:10:45 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Oct 2021 14:10:45 -0400 In-Reply-To: <83mtnm2w8o.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216576 Archived-At: Eli Zaretskii writes: > And 'show' (or 'foo', or any other non-nil value) does NOT show the > matching paren in the echo area when that position is off-screen? It > does here, FWIW. The behavior you see should be explained in the new docstring. Did you miss this part in the diff? +In addition, if the opening paren is not visible on screen, show +its position in the echo area. >> (defcustom blink-matching-paren t >> "Non-nil means show matching open-paren when close-paren is inserted. >> -If t, highlight the paren. If `jump', briefly move cursor to its >> -position. If `jump-offscreen', move cursor there even if the >> -position is off screen. With any other non-nil value, the >> -off-screen position of the opening paren will be shown in the >> -echo area." >> +In addition, if the opening paren is not visible on screen, show >> +its position in the echo area. >> + >> +The valid values are: >> + >> + nil Disable. >> + non-nil Highlight the opening paren. >> + `jump' Briefly move cursor to its position. > ^^^ > What does "its" there allude to? > >> + `jump-offscreen' Briefly move cursor to its position, > > Likewise. The opening paren. What "it" refers to is on the previous line. I don't think this is unclear, but I don't object if you want to improve it. >> + even if the opening paren is not on screen." > > This doesn't update the choices, which is what the original bug report > was about. Yes it does, by changing t to non-nil. Or maybe I don't understand what you are saying. > And I think the new doc string is incomplete, because you > removed the information about showing matches that are far away in the > echo-area. I think you missed a sentence, see above.