From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44317: [PATCH] cperl-mode: Make timeout tests more robust Date: Thu, 29 Oct 2020 14:49:22 -0700 Message-ID: References: <87lffo3fjq.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17941"; mail-complaints-to="usenet@ciao.gmane.io" To: Harald =?UTF-8?Q?J=C3=B6rg?= , 44317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 29 22:50:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYFoA-0004Xo-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 22:50:10 +0100 Original-Received: from localhost ([::1]:47234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYFo9-0000A0-Jq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 17:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYFo2-00009h-Nq for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYFo2-0004p8-EA for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYFo2-0004eW-C5 for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Oct 2020 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44317-submit@debbugs.gnu.org id=B44317.160400817017836 (code B ref 44317); Thu, 29 Oct 2020 21:50:02 +0000 Original-Received: (at 44317) by debbugs.gnu.org; 29 Oct 2020 21:49:30 +0000 Original-Received: from localhost ([127.0.0.1]:55201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFnW-0004dW-Cn for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:49:30 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:40785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFnU-0004dC-D9 for 44317@debbugs.gnu.org; Thu, 29 Oct 2020 17:49:28 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id p93so4580137edd.7 for <44317@debbugs.gnu.org>; Thu, 29 Oct 2020 14:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=BoCFymSdkPW0fVl3VyD2lHSaxlb4HMSD9naLSu4Ssbw=; b=IvKIl+XeTndKz7iXv3w5kGvTGcgI/GhEqWeeIndTOBEcxV8Wh+AfYbGRtWn6gzySxl zpKbi76ymB0CrtYfQ7nM/ZusWeiR/D+iJpBJR6VBP1AxvnXZxMAv+UN62Y7jDX3Dtc/g 9+JuszxsRSaAWEwXnVMp1niRD+1BLZuduv2viS18NSpCw6tJhkiK6nNQqA2z5KItTnpP D++7heg7bAsdbHww6WfvLlVoguD5vP2teGr+siviQdytiCDaMypyIr/rWhDTYMnxInVb hbkUTfq/Tj5kyiPOWq9vKw8j+CeRUyeEjPH+kpZjZ7UvSZbl4qAbYXdEiX2aw5YnZKul wL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=BoCFymSdkPW0fVl3VyD2lHSaxlb4HMSD9naLSu4Ssbw=; b=lXY+hsLiPJ8d1axPfaW325K5VswSOl6gBURX8ac/cMRA6MJEpuxZoGLYTOiAMLly4m mxzbemi48R31gGaUBzIx8vk9eMVM0Ft1nteTAY7j+GBIDVLAV4PSQB+JbJcgB0DQnDfb 3ATGkjMYD1AiSZMppAYngVADc4VgSnK3utRLy3IZWgLzFj9fh1b+oh0IP9EzBcVnjMog QC8ZHc5+ZlFi9FfUPj0EYH57fVenhC/fUlq5Xtq8r5LJpjb62qUFXgFwVc4W+o99LPDF 6Ef9XKp0PY67VMJtj2mWbds483bqc7T2ONFRTixTkRjyQzpXbsr+5CjSRmqxCbHWKY8m pKwA== X-Gm-Message-State: AOAM532F0UeFx7Nt791EJ0gxJ/Vuzv+eQwtYF92vIzsZ9pRzEwK6qUmG Qdd0/SMSjDgSHymghKbMEs0CP6TPr6t8AMGSTgM= X-Google-Smtp-Source: ABdhPJxVdzAY8NuiJLrUV3S+4RDzd+867v/TOdrEC/YrxM6LbNvo98EoC6X1ix7MlVU6kzXWVAB1bXHzH6mNZtmIATA= X-Received: by 2002:aa7:d783:: with SMTP id s3mr6386677edq.214.1604008162577; Thu, 29 Oct 2020 14:49:22 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 29 Oct 2020 14:49:22 -0700 In-Reply-To: <87lffo3fjq.fsf@hajtower> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192010 Archived-At: close 44317 28.1 thanks haj@posteo.de (Harald J=C3=B6rg) writes: > One of the tests in cperl-mode-tests.el starts an external Emacs process > under timeout to check for an endless loop. It turns out that the > timeout of 1 sec is rather short for slower machines. Thanks to recent > ERT which now reports the run time in batch tests, I saw that it takes > about 0.7 seconds on my machine, so I increased the timeout to 2 > seconds. > > I also flagged the test as "expensive" and skip it under older Emacs > versions (I run tests for Emacs version 26.1 and above). Thanks, makes sense. Pushed to master as commit 96e371b44a.