all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master 705292c 1/2: Remove unused DEFSYM
       [not found] ` <20210108135015.D842D20DF3@vcs0.savannah.gnu.org>
@ 2021-01-08 14:13   ` Robert Pluim
  2021-01-08 14:37     ` Stefan Kangas
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2021-01-08 14:13 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Kangas

stefankangas@gmail.com (Stefan Kangas) writes:

> branch: master
> commit 705292c200a6e35127c26a0ff676f41a072fefa4
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
>     Remove unused DEFSYM
>     
>     * src/minibuf.c (syms_of_minibuf) <Qhistory_length>: Remove unused
>     DEFSYM.

subr.el:

  (unless maxelt
    (setq maxelt (or (get history-var 'history-length)
		     history-length)))

Robert



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 705292c 1/2: Remove unused DEFSYM
  2021-01-08 14:13   ` master 705292c 1/2: Remove unused DEFSYM Robert Pluim
@ 2021-01-08 14:37     ` Stefan Kangas
  2021-01-08 15:31       ` Robert Pluim
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2021-01-08 14:37 UTC (permalink / raw)
  To: Robert Pluim, emacs-devel

Robert Pluim <rpluim@gmail.com> writes:

>> branch: master
>> commit 705292c200a6e35127c26a0ff676f41a072fefa4
>> Author: Stefan Kangas <stefan@marxist.se>
>> Commit: Stefan Kangas <stefan@marxist.se>
>>
>>     Remove unused DEFSYM
>>
>>     * src/minibuf.c (syms_of_minibuf) <Qhistory_length>: Remove unused
>>     DEFSYM.
>
> subr.el:
>
>   (unless maxelt
>     (setq maxelt (or (get history-var 'history-length)
> 		     history-length)))

Sorry, I don't follow.  Do you see a problem with this commit?



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 705292c 1/2: Remove unused DEFSYM
  2021-01-08 14:37     ` Stefan Kangas
@ 2021-01-08 15:31       ` Robert Pluim
  2021-01-08 16:43         ` Stefan Kangas
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2021-01-08 15:31 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

Stefan Kangas <stefan@marxist.se> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>>> branch: master
>>> commit 705292c200a6e35127c26a0ff676f41a072fefa4
>>> Author: Stefan Kangas <stefan@marxist.se>
>>> Commit: Stefan Kangas <stefan@marxist.se>
>>>
>>>     Remove unused DEFSYM
>>>
>>>     * src/minibuf.c (syms_of_minibuf) <Qhistory_length>: Remove unused
>>>     DEFSYM.
>>
>> subr.el:
>>
>>   (unless maxelt
>>     (setq maxelt (or (get history-var 'history-length)
>> 		     history-length)))
>
> Sorry, I don't follow.  Do you see a problem with this commit?

Iʼm just worried that thereʼs code that relies on the history-length
symbol existing (perhaps Iʼm being overly paranoid).

Robert



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 705292c 1/2: Remove unused DEFSYM
  2021-01-08 15:31       ` Robert Pluim
@ 2021-01-08 16:43         ` Stefan Kangas
  2021-01-08 18:07           ` Robert Pluim
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2021-01-08 16:43 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

Robert Pluim <rpluim@gmail.com> writes:

> Iʼm just worried that thereʼs code that relies on the history-length
> symbol existing (perhaps Iʼm being overly paranoid).

Unless I'm missing something, it already exists on the Lisp level, since
there's a DEFVAR_LISP ("history-length", ...) further down.

And the compiler should catch any undefined variables in C, no?



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 705292c 1/2: Remove unused DEFSYM
  2021-01-08 16:43         ` Stefan Kangas
@ 2021-01-08 18:07           ` Robert Pluim
  0 siblings, 0 replies; 5+ messages in thread
From: Robert Pluim @ 2021-01-08 18:07 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

Stefan Kangas <stefan@marxist.se> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> Iʼm just worried that thereʼs code that relies on the history-length
>> symbol existing (perhaps Iʼm being overly paranoid).
>
> Unless I'm missing something, it already exists on the Lisp level, since
> there's a DEFVAR_LISP ("history-length", ...) further down.
>

D'oh. Iʼll go away now :-)

> And the compiler should catch any undefined variables in C, no?

Yes.

Robert



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-08 18:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210108135013.27031.26597@vcs0.savannah.gnu.org>
     [not found] ` <20210108135015.D842D20DF3@vcs0.savannah.gnu.org>
2021-01-08 14:13   ` master 705292c 1/2: Remove unused DEFSYM Robert Pluim
2021-01-08 14:37     ` Stefan Kangas
2021-01-08 15:31       ` Robert Pluim
2021-01-08 16:43         ` Stefan Kangas
2021-01-08 18:07           ` Robert Pluim

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.