all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#65704: 29.1; Most code of `project-ignores' seems to be dead code
@ 2023-09-02 16:03 Damien Cassou
  2023-09-02 16:17 ` bug#65704: [PATCH] project.el: Fix bug in project-ignores Damien Cassou
  2023-09-03  0:26 ` bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Dmitry Gutov
  0 siblings, 2 replies; 15+ messages in thread
From: Damien Cassou @ 2023-09-02 16:03 UTC (permalink / raw)
  To: 65704; +Cc: Dmitry Gutov

Hi,

The function `project-ignores' starts like this:

  (cl-defmethod project-ignores ((project (head vc)) dir)
    (let* ((root (nth 2 project))
           backend)
      (append
       (when (and backend
                  (file-equal-p dir root))

It seems to me that `backend' is always going to be nil at this point
and thus the 25-line long `when' block will always return nil without
doing anything.

Am I missing something?

This code seems to have been introduced in commit
785fa801596ad7bb9f838cac865f00de29e253d1 "New user option:
project-vc-extra-root-markers".

Best

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill





^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-09-06 21:16 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-02 16:03 bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Damien Cassou
2023-09-02 16:17 ` bug#65704: [PATCH] project.el: Fix bug in project-ignores Damien Cassou
2023-09-03  0:26 ` bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Dmitry Gutov
2023-09-04 16:03   ` Damien Cassou
2023-09-04 18:30     ` Dmitry Gutov
2023-09-04 20:11       ` Damien Cassou
2023-09-04 20:17         ` Dmitry Gutov
2023-09-05  7:58           ` Damien Cassou
2023-09-05 14:09             ` Dmitry Gutov
2023-09-05 20:22               ` Damien Cassou
2023-09-06 19:12               ` Damien Cassou
2023-09-06 21:16                 ` Dmitry Gutov
2023-09-04 18:31   ` Dmitry Gutov
2023-09-04 18:48     ` Eli Zaretskii
2023-09-04 18:58       ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.