From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 4449301: * etc/NEWS: Improve documentation of 'package-initialize'. Date: Mon, 18 Nov 2019 15:58:06 +0100 Message-ID: References: <20191022021600.2389.91268@vcs0.savannah.gnu.org> <20191022021602.B41B3209DE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182600"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 18 15:58:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWiUO-000lFV-1s for ged-emacs-devel@m.gmane.org; Mon, 18 Nov 2019 15:58:52 +0100 Original-Received: from localhost ([::1]:35170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWiUM-0004N5-UE for ged-emacs-devel@m.gmane.org; Mon, 18 Nov 2019 09:58:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32940) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWiTs-0004Mr-Mn for emacs-devel@gnu.org; Mon, 18 Nov 2019 09:58:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWiTr-0003Ag-Bw for emacs-devel@gnu.org; Mon, 18 Nov 2019 09:58:20 -0500 Original-Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:33255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWiTr-0003AQ-4I for emacs-devel@gnu.org; Mon, 18 Nov 2019 09:58:19 -0500 Original-Received: by mail-pl1-x631.google.com with SMTP id ay6so9944598plb.0 for ; Mon, 18 Nov 2019 06:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UYFtMgsSw28zWZfF8cep0RxydiypDyA6ZxiDSAJdCj8=; b=ch77sbWrnJHcZoeHmUolIca3yEg45zkig0fcXA4Y1tSYCnhdjnDhcRLa2/xVd/h6OX PV0D1xIbnfFQ9asFdrxlyA9p6be4SS1YAWEcwqeN15Rulys9blERwkbLW6kwjTom1fb+ PCZhJEGC7NI7VJMa4nQcZxYE0afv2jcFmY/yl35FjGx+yuFuAvrvN6cxSj3o+8YAjiIO RnjsfLHYwYlwYVRqCt7xU8m2xCPQkiwKYon+n/7kQeASOshiUyFf7i9pVlK7hgyVyYNl 9rXdUHPpuyVNhFZHhqJGO/Y7zqvLXNWKAWHj4UHzLVgr4Juzajplnva4brWI7PyuC6cI PTLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UYFtMgsSw28zWZfF8cep0RxydiypDyA6ZxiDSAJdCj8=; b=ucv/Qv2HRMx3nH4Jj1dxHCrkXapsOl3YiQcpLoECSL7Q6vLiM0sCHSfr2F7tEmLX/5 nhzw26cb3EqC3DrXNaE69GA7AtT8E4ECW5fstMnDp/FSWyEMRcrSWIbid8zLq06Viy8Y f7CZvWp26U+RQ6GOSz893EBUz+/PxqeBc3Kw8cbRu+5XdJOWl/48ONLXg+elnNj2m5j/ ++r8rtz67/YEHbZs8291tM4XnFv6MoRK19B4oDY5cKnaULofba0XevXb0KHynVgS7FsW YCgX9dhkFo4ZLR/r6I1SXRMTl+rEOlLJ4We6aooMrac70gRSrkWsziML0IWal9KO8W5Y jjaw== X-Gm-Message-State: APjAAAV/s5yhmb1vTDJkNC/wH2r9nNcMfXHmIIjsERU1JbK8xKoxo5Da iZmx6wcRE4ItcmQqwR3tuW4XJLeMZpu4kMleQHU= X-Google-Smtp-Source: APXvYqyeWFdzMXBJnDV1+Cd5vR9nhKaILKGsKqGtMD1V3mx0SLPBYbGgatG9W/NYy30DWkIkssvRkwqIFGXLgz/gH0c= X-Received: by 2002:a17:90a:a40f:: with SMTP id y15mr41056406pjp.106.1574089097946; Mon, 18 Nov 2019 06:58:17 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::631 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242370 Archived-At: Stefan Monnier writes: > I'm not sure if there's much harm in keeping it as a defcustom, so I'll > let someone else decide whether we should change it. But if we do want > to change it, the patch looks OK to me in this respect. OK, I must have misunderstood you above and believed you agreed that it should be changed into a defvar. Thinking a bit more about this, maybe we should add some general machinery to specify that particular variables gets placed in the early init file by default? It could be a new property ':early-init t', where Emacs inserts these particular variables into the early init file instead of the init file. Perhaps we could also add a new variable 'custom-file-early' analogous to 'custom-file'. Would that make sense? > > I've also added documentation to package-load-list and > > package-user-dir to explain the above quirks. > > But this doesn't mention the fact that it still works if they use > `package-quickstart`. Please expect a new patch once I find the time to work on it. > > Perhaps it would make sense to create a new node "initialization of > > packages" which could describe all this. > > Yes. Maybe it should be a bit more general and include discussion of > customize settings. IOW it could talk about dependencies and ordering > between package.el, custom.el, and "manual Elisp settings". Agreed, to make it more general was my thinking too. I'll get to work on such a section, which I'll add in packages.texi and name "Initialization of Packages". > > 2. Should package-quickstart have a :set attribute with a value of > > 'package-quickstart-refresh? > > I don't think so: the refresh should happen when the set of > installed/activated packages changes, whereas what you suggest would > cause a refresh to happen at every Emacs startup. > > But I guess it does deserve a :set function, which should take care to > run `package-quickstart-refresh` if there's no quickstart file yet, or > to delete the quickstart file when set to nil (in both cases it should > maybe prompt the user before actually doing it?). Makes sense. I could probably work on that too, if no one beats me to it. I haven't thought about the prompting, so I don't have an opinion about that yet. Best regards, Stefan Kangas